Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode_memcached commit注释 #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

panzg123
Copy link

添加100+行自己的理解。thanks.

@daoluan
Copy link
Owner

daoluan commented Jan 26, 2016

hi, panzheng.

上次收到了你的邮件,当时有点事没回。很高兴有人能一起来维护这个源码相关的项目,里面还有一些尚未完成的解析,因为工作原因,部分工作被落下,后面尽力和你一起补上,期间我们也是相互学习。
多人一起维护项目,最好能有一个约定,如此可以方便读者。

  1. 注释尽可能详尽细致,站在初学者的角度来看问题即可
  2. 注释尽可能使用 ‘// ’ 这样的形式并且和代码对齐。一个项目注释风格最好能统一。举一个不对齐的例子:
    [image: 内嵌图片 1]

基本这两点即可,看了提交的文件注释很详细,但_风格上我们最好统一一下_。

祝新年好。

2016-01-26 16:46 GMT+08:00 panzhengguang notifications@github.com:

添加100+行自己的理解。thanks.

You can view, comment on, or merge this pull request online at:

#2
Commit Summary

  • 线程模型
  • 内存管理
  • 状态机

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#2.

郑思愿
http://daoluan.net

@panzg123
Copy link
Author

hi, daoluan
谢谢你的回复,目前我的代码能力还很弱,Git 也不是很熟,不足之处还请指导。
祝顺!

@panzg123
Copy link
Author

daoluan,你好!这一阶段的注释任务基本告一段落,请多多指导!明天我就放假回家了。也祝你新年快乐。=.=

@daoluan daoluan force-pushed the master branch 2 times, most recently from e533a80 to e136600 Compare June 26, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants