Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix manager role in admin users overview #5359

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

stefan0xC
Copy link
Contributor

due to this hack the returned type in the overview has changed:

// HACK: Convert the manager type to a custom type
// It will be converted back on other locations
let user_org_type = self.type_manager_as_custom();

due to the hack the returned type has changed
@BlackDex
Copy link
Collaborator

BlackDex commented Jan 7, 2025

Hmmm, it might also cause issues with the feature to adjust the user status, but not sure.

@BlackDex
Copy link
Collaborator

BlackDex commented Jan 7, 2025

That seems to still work fine. It might be an option to set accessAll in case it is modified via the admin interface, but that is not something which is trivial, and nobody complained. Also, if that user was configured already with such rights, then we would change that too.

@BlackDex BlackDex merged commit bc913d1 into dani-garcia:main Jan 7, 2025
5 checks passed
@stefan0xC stefan0xC deleted the fix-admin-users branch January 7, 2025 11:47
@stefan0xC
Copy link
Contributor Author

Yeah. I mean I have not tested this extensively (what happens if I change a User to Manager via /admin, etc.) but without this change there will be an exception raised and no scripts will run. That's how I found it because it was impossible to delete a invited user via /admin interface.

@BlackDex
Copy link
Collaborator

BlackDex commented Jan 7, 2025

I tested it, and it seems to work just fine :)

dfunkt pushed a commit to dfunkt/vaultwarden that referenced this pull request Jan 7, 2025
due to the hack the returned type has changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants