Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post status to github rather than breaking the build #279

Closed
shilman opened this issue Jun 11, 2017 · 2 comments
Closed

Post status to github rather than breaking the build #279

shilman opened this issue Jun 11, 2017 · 2 comments

Comments

@shilman
Copy link

shilman commented Jun 11, 2017

why

Currently when there are any fail messages, Danger breaks the build:

process.exitCode = 1

If the token has PR access, it should post a build status instead rather than completely breaking the build.

what

Try to post the status, set exitCode to 1 if this fails

@macklinu
Copy link
Member

Status posting has been shipped in danger@0.21.0 - @shilman, please update and let us know what you think!

Here's an example from a private repo at work where Danger found one warning and no failures, which marks the PR with a "success" status and the there-are-fixable-things message. 🙂

image

Let's keep this issue open to add some more tests around this feature. 👍

@shilman
Copy link
Author

shilman commented Jun 13, 2017

That was fast—thanks for the fast turnaround! And it works like a charm: storybookjs/storybook#1251

add_danger_to_start_automating_some_code_review_tasks_by_shilman_ _pull_request__1251_ _storybooks_storybook_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants