Reduce body allocation and copying #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 29, 2019 14:11
…some duplication between JSON and Transit support.
…he JSON and Transit memory optimizations.
|
Greetings - we recently upgraded to clj-http 3.10.0. The following doesn't work in 3.10.0, but it worked in 3.9.1. In 3.10.0, we get a java.io.IOException Stream Closed error If we remove :as :json, we don't get that error, but the body isn't coerced to a clj map. I'm planning on looking through changes leading up to 3.10.0, but before I did that, I figured that I'd post the error for early awareness. |
rymndhng
added a commit
that referenced
this pull request
Sep 27, 2020
Connections are not closing immediately after coercing the body using transit. This is a regression introduced in #475. Previously, the response body always was also transferred into an intermediate byte-array which will read bytes until the stream is empty, and automatically close the connection. Since we no longer have this implicit behavior, the body coercion middleware must close the inputstream after reading a value. Fixes #564
This was referenced Sep 27, 2020
rymndhng
added a commit
that referenced
this pull request
Nov 15, 2020
Connections are not closing immediately after coercing the body using transit. This is a regression introduced in #475. Previously, the response body always was also transferred into an intermediate byte-array which will read bytes until the stream is empty, and automatically close the connection. Since we no longer have this implicit behavior, the body coercion middleware must close the inputstream after reading a value. Fixes #564
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes various intermediate byte arrays and strings in body decoding that were unnecessary. JSON and Transit decoding get the most benefit.
I didn't have time to figure out every format and it seems that some of them would need changes to other libraries like
ring.util.codec. dakrone/cheshire#139 would also enable a bit more gains for JSON decoding.