Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility(result): treat equality by value instead of by reference #471

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

daht-x
Copy link
Owner

@daht-x daht-x commented Aug 22, 2024

Pull request

Thank you very much for your contribution

Please read and follow our code of conduct and
contributing guidelines.

Table of contents

  1. Tickets
  2. Description
  3. Additional information

Tickets

Undefined.

Top

Description

The default behavior of the ==, !=, Equals, and GetHashCode members was overridden to handle value equality instead of reference equality, as it is expected that a container or wrapper should be compared based on its contents rather than its reference.

Top

Additional information

Undefined.

Top

@daht-x daht-x added priority: high Indicates a high priority status: pending Indicates a pending status topic: compatibility Indicates a relationship with a process or action that affects the compatibility labels Aug 22, 2024
@daht-x daht-x self-assigned this Aug 22, 2024
@daht-x daht-x added status: approved Indicates an approved status and removed status: pending Indicates a pending status labels Aug 22, 2024
@daht-x daht-x merged commit 654ae82 into main Aug 22, 2024
7 checks passed
@daht-x daht-x deleted the daht-x/compatibility/result branch August 22, 2024 01:35
@daht-x daht-x added status: inactive Indicates an inactive status and removed status: approved Indicates an approved status labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Indicates a high priority status: inactive Indicates an inactive status topic: compatibility Indicates a relationship with a process or action that affects the compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant