Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d3-zoom doesn't work with core-js >3.6 on IE11 #200

Closed
Yohandah opened this issue Jan 29, 2020 · 6 comments
Closed

d3-zoom doesn't work with core-js >3.6 on IE11 #200

Yohandah opened this issue Jan 29, 2020 · 6 comments

Comments

@Yohandah
Copy link

Yohandah commented Jan 29, 2020

Hello,

I have an Angular 8 project that uses d3-zoom 1.8.3, and my project uses core-js which is normal for an Angular project.

When compiling (ng build or ng serve) with core-js 3.5 as a dependency my app works fine in Evergreen browsers, and IE11.

When compiling with core-js 3.6 as a dependency, my app works fine in Evergreen browsers, but on IE 11 I have the following error :

unknown type z and it throws when doing d3Zoom.zoom().on("zoom", () => { });

You don't even need to do something in the callback, just calling .on will throw the error ...

@ashwini-balnaves
Copy link

I have this exact same issue.

@mbostock
Copy link
Member

mbostock commented Feb 4, 2020

This sounds like a compiler issue, not a library issue. Please see this related discussion: d3/d3-color#68 (comment)

@mbostock mbostock closed this as completed Feb 4, 2020
@Yohandah
Copy link
Author

Yohandah commented Feb 4, 2020

@mbostock I don't think it is, disabling optimizer doesn't fix it, and the issue is happening with dev mode and prod mode. It really looks like an incompatibility with core-js > 3.6 ... with IE11.

I'll open an issue in the core-js or Angular repo to see what they think about that

@mbostock
Copy link
Member

mbostock commented Feb 4, 2020

Do you have a stack trace? Can you try debugging? From what you’ve shared it looks like this line:

https://github.com/d3/d3-dispatch/blob/4f868212fc5b425cd11c07f929fef8a77a46adf3/src/dispatch.js#L19

@Yohandah
Copy link
Author

Yohandah commented Feb 4, 2020

@mbostock
It does looks like that. I have tried to debug it but haven't succeeded.

I will try to reproduce the bug in a separate repo and link it to you.

@a616101
Copy link

a616101 commented Jun 23, 2020

Wait for this problem to be solved,maybe this issue will disappear.
==> core-js@3.6 breaks xregexp patterns on IE11

jebrosen added a commit to Dfam-consortium/Dfam-Portal that referenced this issue Nov 6, 2020
Suspected cause is <zloirock/core-js#751>, via
<d3/d3-zoom#200>, which is used in SODA.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants