Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the BumpRadial curve only works with two-point lines #191

Closed
mbostock opened this issue Jan 8, 2022 · 0 comments · Fixed by #193
Closed

the BumpRadial curve only works with two-point lines #191

mbostock opened this issue Jan 8, 2022 · 0 comments · Fixed by #193

Comments

@mbostock
Copy link
Member

mbostock commented Jan 8, 2022

This bug isn’t visible externally, but it makes the BumpRadial class a bad example to copy from since it doesn’t work for lines with three or more points.
Fil added a commit that referenced this issue Feb 21, 2022
@Fil
bumpRadial could be used with multiple points
5eaa0f6 
fixes #191

since bumpRadial is not exported, a visual test is available at https://observablehq.com/@d3/bumpradial-191
@Fil Fil mentioned this issue Feb 21, 2022
Merged
mbostock added a commit that referenced this issue Dec 20, 2022
@Fil @mbostock
bumpRadial could be used with multiple points (#193)
8fe68eb 
* bumpRadial could be used with multiple points
fixes #191

since bumpRadial is not exported, a visual test is available at https://observablehq.com/@d3/bumpradial-191

* only increment once

* style

Co-authored-by: Mike Bostock <mbostock@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bumpRadial could be used with multiple points d3/d3-shape
1 participant
@mbostock