path.digits #272
Merged
path.digits #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
commented
Dec 18, 2022
src/path/string.js
Outdated
| let i = 1; | ||
| this._ += strings[0]; | ||
| for (const j = strings.length; i < j; ++i) { | ||
| this._ += +arguments[i].toFixed(digits) + strings[i]; |
There was a problem hiding this comment.
We might need additional coercion here if the stream is passed non-numeric input.
|
I did some benchmarking in https://observablehq.com/d/07584fd387781785 and learned some things.
So, I’d like to use the Math.round approach. We learned six years ago in d3/d3-path#10 (comment) that Math.round is faster than number.toFixed, so I’m just repeating that lesson here. |
|
Related d3/d3-path#11 which also adopted string concatenation over array.join for faster performance. |
marcelgerber
added a commit
to owid/owid-grapher
that referenced
this pull request
Jan 26, 2023
mlbrgl
pushed a commit
to owid/owid-grapher
that referenced
this pull request
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271. Related d3/d3-path#12.