Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geoStitch and geoQuantize should NOT modify in-place. #88

Closed
mbostock opened this issue Jan 19, 2017 · 1 comment
Closed

geoStitch and geoQuantize should NOT modify in-place. #88

mbostock opened this issue Jan 19, 2017 · 1 comment
Assignees
@mbostock

Comments

@mbostock
Copy link
Member

This was a lazy decision since they were only used on the command-line, but now that they are accessible programmatically, we should have them return copies. (And bump the major version number of this module to be safe.)
@mbostock mbostock self-assigned this Jan 19, 2017
@mbostock
Copy link
Member Author

Related TopoJSON 3.0 effort:

mbostock added a commit that referenced this issue Mar 31, 2017
@mbostock
Make d3.geoStitch less destructive.
2328f48 
Related #88. It’s still destructive for Polygon and MultiPolygon!
mbostock added a commit that referenced this issue Mar 31, 2017
@mbostock
Make d3.geoStitch non-destructive!
202a0aa 
Related #88.
@bradoyler bradoyler mentioned this issue Apr 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbostock mbostock

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbostock