-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve clicking with modifiers. #8114
Conversation
Thanks for taking the time to open a PR!
|
Flaky failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Any reason to leave out the
{meta}
modifier? - The type modifiers also have aliases, to account for Mac vs Windows, etc. Should we also implement:
optionKey
(alias foraltKey
),controlKey
(alias forctrlKey
),meta
/commandKey
/cmdKey
?
No. I just forgot it. I'll cover them tomorrow. |
Flaky failures. |
Dismissing my previous review as addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think we just need docs for this and it's good to go.
Add doc at cypress-io/cypress-documentation#3062 |
User facing changelog
You can not send click with simple options like this:
Additional details
cy.devices.keyboard
insideclick
.How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation
? => Coming soon...type definitions
?cypress.schema.json
?