-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typing into shadow dom inputs #7847
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. It would probably be nice to have better unit tests surrounding the code written... not just 1 integration test.
I'd honestly advocate for a public lib file supporting experimental shadow DOM work so we can group all of the relevant methods in one experimental file.
User facing changelog
Additional details
We do various checks for typing, including ensuring that we're typing into the active element. We determine the active element from the
document
, but this doesn't work for the shadow dom since it's intentionally hidden. Instead, the active element needs to be determined from the element's shadow root.How has the user experience changed?
Tests that type into shadow dom inputs no longer fail with validation errors and no longer require
{force: true}
to pass.PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?