-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formats number string #5557
Formats number string #5557
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Thanks for reopening - although this PR is now converting the files to JS without the decaffeinated fixes, and causing conflicts. You'll need to pull down develop - which now has #5556 merged in and work off from there. |
User facing changelog
Formats number strings in test results in quotes. In other words, 25 -> '25'.
Additional details
Why was this change necessary:
What is affected by this change?
Not much. I added a test to show this case clearly.
Any implementation details to explain?
Not much. Just fixed some regexes.
NOTE: As it is based on decaffeination of #5556, it should be merged after that PR. When that PR is merges, I'll force-push this branch again without decaffeination.
How has the user experience changed?
Before: above.
After 1 in #5543:

After 2:

PR Tasks
Has a PR for user-facing changes been opened incypress-documentation
?Have API changes been updated in thetype definitions
?Have new configuration options been added to thecypress.schema.json
?