3.5.0 - fix click events sent to proper element, respect selection changes during cy.click

[kuceb]

• fix click during overlay on mousedown, fix selectionchange during focus handler
  fix 3.5.0 cy.click() behavior change caused broken tests #5459
• fix no respecting selection changes during click/type
  fix 3.5.0 Input select-on-focus no longer working #5456
• replacing selection during modifier key
  fix Typing a modifier key anywhere removes selected text from an input in 3.5.0 #5439

User facing changelog

• fix click events not being sent to correct elements during cy.click() 3.5.0 cy.click() behavior change caused broken tests #5459
• fix respect focus selection changes during cy.type() 3.5.0 Input select-on-focus no longer working #5456
• fix overwriting selected text while typing a modifer key during cy.type() Typing a modifier key anywhere removes selected text from an input in 3.5.0 #5439

Additional details

• links to issues are included

How has the user experience changed?

• When using cy.type() on input that has handler on focus, and changes selection, we no longer overwrite that selection
• When an element moves in front of the cursor during the mousedown event, we no longer send a click to it

PR Tasks

• Have tests been added/updated?
• [NA] Has a PR for user-facing changes been opened in cypress-documentation?
• [NA] Have API changes been updated in the type definitions?
• [NA] Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[jennifer-shehane]

Can you add any links to the bugs this PR is fixing in the tests or code that was added?

Going to pull this down now and actually run it against the open issues.

[jennifer-shehane]

I confirmed this fixes #5459 and #5456 when running in this branch.

[kuceb]

@jennifer-shehane I added an issue this fixes, #5439 see this commit 5dd1a52

[jennifer-shehane]

I confirmed this also fixes #5439

[jennifer-shehane]

Does this address this issue? #5518