Truncate httpprops in error message to show more chars #5150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jennifer-shehane
commented
Sep 16, 2019
jennifer-shehane
commented
- truncate httpProps shown in error messages to 2000 chars instead of 100 chars
- close Should not truncate full url during cy.request() in stdout #3145
let’s see what snapshots look like 🤞
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
brian-mann
requested changes
Sep 26, 2019
| @@ -0,0 +1,4 @@ | |||
| describe "when status code isnt 2xx or 3xx", -> | |||
| it "fails", -> | |||
| cy.request("http://localhost:2294/myreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallylong | |||
There was a problem hiding this comment.
|
@jennifer-shehane are you fixing these conflicts? |
# Conflicts: # packages/server/__snapshots__/4_request_spec.coffee.js
grabartley
pushed a commit
to grabartley/cypress
that referenced
this pull request
Oct 6, 2019
* bump up truncation of formatting http props to 2000 chars instead of 100 let’s see what snapshots look like 🤞 * Add a test for something with a long prop (url) to have snapshot to not truncate. * remove unnecessary module Co-authored-by: Brian Mann <brian.mann86@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.