Renames: issue 2957 #4879
Merged
Renames: issue 2957 #4879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuceb
force-pushed
the
renames-issue-2957
branch
2 times, most recently
from
e865084 to
2c7c842
Compare
kuceb
force-pushed
the
renames-issue-2957
branch
from
2c7c842 to
ceebbb4
Compare
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
kuceb
force-pushed
the
renames-issue-2957
branch
from
ceebbb4 to
2ee3347
Compare
brian-mann
requested changes
Aug 1, 2019
brian-mann
previously approved these changes
Aug 1, 2019
kuceb
force-pushed
the
renames-issue-2957
branch
from
42bd618 to
0209f3d
Compare
brian-mann
requested changes
Aug 1, 2019
brian-mann
approved these changes
Aug 6, 2019
| @@ -4334,7 +4333,7 @@ describe('src/cy/commands/actions/type', () => { | |||
| cy.on('fail', (err) => { | |||
| expect(this.logs.length).to.eq(2) | |||
|
|
|||
| const allChars = _.keys(Keyboard.specialChars).concat(_.keys(Keyboard.modifierChars)).join(', ') | |||
| const allChars = _.keys(cy.devices.keyboard.specialChars).concat(_.keys(cy.devices.keyboard.modifierChars)).join(', ') | |||
There was a problem hiding this comment.
Now that I see this - these should probably be constants on the class, not the instance. approving anyway.
grabartley
pushed a commit
to grabartley/cypress
that referenced
this pull request
Oct 6, 2019
* [rename only] {keyboard,mouse}.js
* refactor keyboard/mouse into cy/
* fix cy.type for refactor
* fix e2e test error
* commands now recieve devices as separate prop
* add .history to .estlintignore
* fix linting errors
* remove passing log and devices to commands, pull devices off of cy
* fix commands.coffee
Co-authored-by: Brian Mann <brian.mann86@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactors cypress/{keyboard,mouse} utils into cy/ to manage them as stateful utils on cy.
decaffeinate
actions/type.coffeeno tests needed, this is a refactor
waiting on Decaf simulated type fixes 2 #4906
need input:
cy.internaltocy.devices