Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulated type fixes #4870

Merged
merged 137 commits into from
Oct 23, 2019
Merged

simulated type fixes #4870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
137 commits
Select commit Hold shift + click to select a range
9cd40ad
cleanup type_spec, allow unused-vars for args
kuceb Jul 18, 2019
3671278
fix missing return
kuceb Jul 18, 2019
e38ffa5
rename mouse/keyboard
kuceb Jul 16, 2019
e31ae9c
apply changes on this branch with rename
kuceb Jul 16, 2019
2adf013
temp 07/18/19 [skip ci] type_spec minor changes
kuceb Jul 18, 2019
cc27fec
Merge remote-tracking branch 'origin/develop' into issue-2957
kuceb Jul 18, 2019
57b0e0e
temp 07/19/19 [skip ci]
kuceb Jul 19, 2019
ea73b8f
Merge remote-tracking branch 'origin/develop' into issue-2957
kuceb Jul 19, 2019
fa2fbcf
temp 07/22/19 [skip ci]
kuceb Jul 22, 2019
9ca64cd
Merge remote-tracking branch 'origin/develop' into issue-2957
kuceb Jul 22, 2019
c8424ef
temp 07/22/19 [skip ci]
kuceb Jul 22, 2019
b13051d
Merge remote-tracking branch 'origin/develop' into issue-2957
kuceb Jul 26, 2019
d744235
remove accidental spec, use beforeEach visit in click_spec
kuceb Jul 26, 2019
b96cefa
Merge remote-tracking branch 'origin/develop' into issue-2957
kuceb Jul 26, 2019
645476d
Merge remote-tracking branch 'origin/develop' into issue-2957
kuceb Jul 26, 2019
a035caf
Merge remote-tracking branch 'origin/issue-2957' into issue-2957
kuceb Jul 26, 2019
be2fdec
Merge remote-tracking branch 'origin/develop' into issue-2957
kuceb Jul 29, 2019
994b74f
add tests for cy.trigger changes
kuceb Jul 29, 2019
76f8307
re-run build
kuceb Jul 29, 2019
de2dd0d
Merge remote-tracking branch 'origin/develop' into issue-2957
kuceb Jul 29, 2019
e1fb2eb
extract simulated type from native events
kuceb Jul 30, 2019
13ef614
most type_spec passing until tab
kuceb Aug 2, 2019
9977737
Merge remote-tracking branch 'origin/develop' into issue-2957
kuceb Aug 8, 2019
5a123bf
add typedefs
kuceb Aug 8, 2019
53771dc
temp 08/08/19 [skip ci]
kuceb Aug 8, 2019
3db8363
fix type_spec, click_spec
kuceb Aug 8, 2019
977a19e
fix console table event table logging
kuceb Aug 11, 2019
5d58038
Merge branch 'develop' into issue-2957
kuceb Aug 11, 2019
ef536c5
fix spec utils
kuceb Aug 12, 2019
e7fcfa4
temp 08/12/19 [skip ci]
kuceb Aug 12, 2019
aac8a38
Merge remote-tracking branch 'origin/develop' into simulated-type-fixes
kuceb Aug 12, 2019
04123ab
large changes to selection.ts, working type_spec, eslint changes
kuceb Aug 13, 2019
87ba79a
fix elements util, cleanup debugging code
kuceb Aug 13, 2019
2f1889a
fix linting rules
kuceb Aug 13, 2019
f5fe2d5
fix type_spec in electron by using plain Event contructor
kuceb Aug 14, 2019
9202ff6
fix invalid clicking-into-iframe spec
kuceb Aug 14, 2019
44eb740
address review, cleanup
kuceb Aug 15, 2019
357ef29
use webpack-preprocessor (required for typescript files)
kuceb Aug 15, 2019
7311aa4
fix invalid connectors_spec
kuceb Aug 15, 2019
478c493
chore(lint): fix linting, since changed rules
kuceb Aug 15, 2019
733dad6
fix not borrowing property getter for maxlength
kuceb Aug 29, 2019
9dda4ce
Merge remote-tracking branch 'origin/develop' into simulated-type-fixes
kuceb Sep 5, 2019
c1ea88b
Merge remote-tracking branch 'origin/develop' into issue-2957
kuceb Sep 5, 2019
32fa7e8
Merge remote-tracking branch 'origin/develop' into issue-2957
kuceb Sep 25, 2019
1097638
temp 09/25/19 [skip ci]
kuceb Sep 25, 2019
799631a
Merge remote-tracking branch 'origin/develop' into issue-2957
kuceb Sep 26, 2019
f7ab2eb
add test for clicking checkbox, cleanup click_spec
kuceb Sep 26, 2019
fbc43eb
document mouse click and mouse move algo, adjust mouse move, add test…
kuceb Sep 27, 2019
f12ff55
Merge branch 'develop' into issue-2957
brian-mann Sep 29, 2019
83a35ed
cleanup / formatting
brian-mann Sep 29, 2019
7a229f9
scope the getCommandLogWithText to the active runnable to prevent lea…
brian-mann Sep 30, 2019
adb6f2c
cleanup tests, make values static so tests pass consistently
brian-mann Sep 30, 2019
5683645
begin implementation for returning fromAutWindow
brian-mann Sep 30, 2019
0eebba1
move describe block with the others
brian-mann Sep 30, 2019
9f09c3c
refactor actions to DRY up duplicated logic between click/dblclick/ri…
brian-mann Sep 30, 2019
807ada5
remove comment
brian-mann Sep 30, 2019
138454a
Merge remote-tracking branch 'origin/develop' into issue-2957
kuceb Oct 3, 2019
e2182ef
Merge remote-tracking branch 'origin/issue-2957' into issue-2957
kuceb Oct 4, 2019
b4b160a
fix iframe coords and test
kuceb Oct 4, 2019
c8ea056
Merge branch 'issue-2957' into simulated-type-fixes
kuceb Oct 4, 2019
1977a39
temp 10/06/19 [skip ci]
kuceb Oct 6, 2019
460466a
Merge branch 'develop' into issue-2957
jennifer-shehane Oct 7, 2019
5bb77e4
rename fromDocCoords->fromWindowCoords, fix type_spec ux test
kuceb Oct 7, 2019
69c413e
Merge remote-tracking branch 'origin/issue-2957' into issue-2957
kuceb Oct 7, 2019
1fe0ed4
temp 10/07/19 [skip ci]
kuceb Oct 7, 2019
c9a6702
Merge branch 'issue-2957' into simulated-type-fixes
kuceb Oct 7, 2019
1640ebb
fix after merge from mouse-fixes branch / develop
kuceb Oct 7, 2019
0d7b16f
Merge remote-tracking branch 'origin/develop' into simulated-type-fixes
kuceb Oct 7, 2019
92b73f6
temp 10/08/19 [skip ci]
kuceb Oct 8, 2019
46c3b5a
Merge remote-tracking branch 'origin/develop' into issue-2957
kuceb Oct 10, 2019
cb377a3
Merge remote-tracking branch 'origin/develop' into issue-2957
kuceb Oct 10, 2019
56e46fe
Merge branch 'issue-2957' into simulated-type-fixes
kuceb Oct 10, 2019
3050717
Revert "temp 10/08/19 [skip ci]"
kuceb Oct 10, 2019
ea36638
remove only, fix contenteditable test
kuceb Oct 10, 2019
63979e9
add test for datetime-local inputs
kuceb Oct 10, 2019
127fb33
add webpack devdep
kuceb Oct 10, 2019
7a43418
fix debugging code
kuceb Oct 10, 2019
5aa6e5e
fix force:true on hidden input
kuceb Oct 10, 2019
33f6106
up timeout for test in ci
kuceb Oct 10, 2019
f0c5826
Merge remote-tracking branch 'origin/develop' into simulated-type-fixes
kuceb Oct 10, 2019
a7b45f3
tighten up method, remove unnecessary arg
brian-mann Oct 11, 2019
8389bf2
Merge remote-tracking branch 'origin/issue-2957' into issue-2957
brian-mann Oct 11, 2019
67443b5
add debug logic for retries to console.error() non cypress errors
brian-mann Oct 11, 2019
07e2f72
renamed fromWindow -> fromElWindow, and fromViewport -> fromElViewport
brian-mann Oct 11, 2019
de38df7
handle calculating the fromElWindow coordinates inline
brian-mann Oct 11, 2019
5c8a625
extract out function for clarity, receive consistent arg names
brian-mann Oct 11, 2019
a18dd32
cleanup, add lots of comments
brian-mann Oct 11, 2019
706b10c
Merge branch 'develop' into issue-2957
brian-mann Oct 11, 2019
2c11c83
Merge remote-tracking branch 'origin/develop' into issue-2957
kuceb Oct 11, 2019
6c33960
Merge branch 'issue-2957' into simulated-type-fixes
kuceb Oct 11, 2019
855ef95
fix display specific test
kuceb Oct 15, 2019
85baac3
fix type follow focus when redirect on focus
kuceb Oct 15, 2019
653d1f2
cleanup new follow focus test
kuceb Oct 15, 2019
cfa6361
upgrade eslint-plugin-dev to 5.0.0
kuceb Oct 16, 2019
8cd181b
more [lint fixes]
kuceb Oct 16, 2019
dfdee3e
use typescript in driver
kuceb Oct 16, 2019
0f94508
Merge branch 'develop' into upgrade-eslint-plugin-dev
kuceb Oct 17, 2019
bef8bb4
Merge branch 'upgrade-eslint-plugin-dev' into ts-in-driver
kuceb Oct 17, 2019
08c0361
Merge remote-tracking branch 'origin/develop' into ts-in-driver
kuceb Oct 17, 2019
410673d
cleanup minor
kuceb Oct 17, 2019
c889c2f
remove unneeded file
kuceb Oct 17, 2019
344a625
mild refactor webpack configs
kuceb Oct 17, 2019
6e9e577
Merge branch 'develop' into ts-in-driver
kuceb Oct 17, 2019
321d3c0
fix elements.ts
kuceb Oct 17, 2019
f716c17
Merge remote-tracking branch 'origin/ts-in-driver' into ts-in-driver
kuceb Oct 17, 2019
68c711e
fix isTextLike signature change
kuceb Oct 17, 2019
9780a15
fix isType check, fix type_spec
kuceb Oct 17, 2019
77e9732
actually use webpack-preprocessor
kuceb Oct 17, 2019
9a00c61
Merge branch 'ts-in-driver' into simulated-type-fixes
kuceb Oct 17, 2019
be9cf80
fix isType domUtil
kuceb Oct 17, 2019
f03e89c
fix connectors_spec
kuceb Oct 17, 2019
16700be
cleanup connectors_spec
kuceb Oct 17, 2019
3475281
address feedback- cleanup, add comments, refac
kuceb Oct 18, 2019
b458e5b
answer: no, need index.js
kuceb Oct 18, 2019
76667f8
Merge branch 'ts-in-driver' into simulated-type-fixes
kuceb Oct 18, 2019
20cc00a
Merge remote-tracking branch 'origin/develop' into ts-in-driver
kuceb Oct 18, 2019
b01aac7
Merge branch 'ts-in-driver' into simulated-type-fixes
kuceb Oct 18, 2019
b968ec4
cleanup after driver typescript PR
kuceb Oct 18, 2019
042d94f
fix keyboard getActiveModifiers
kuceb Oct 18, 2019
ae1460b
fix(driver:keyboard): fix typing negative numbers with existing text …
kuceb Jul 19, 2019
c20e849
remove debugging code, cleanup
kuceb Oct 18, 2019
de8a766
link fixed issues in tests, actually fix one issue
kuceb Oct 22, 2019
2856159
cleanup remove dead code
kuceb Oct 22, 2019
45d3e87
remove unused helper
kuceb Oct 22, 2019
df0583b
add test for #2166
kuceb Oct 22, 2019
1a62a9d
pay no attention to the code and implementation changing... add tests…
kuceb Oct 22, 2019
3944753
mark fix for issue #3316
kuceb Oct 22, 2019
3e71ffa
mark fix for issue #3722
kuceb Oct 22, 2019
0c83cae
rename elements.isType -> elements.isInputType for clarity
brian-mann Oct 23, 2019
2ed4ae0
restructure keyboard a bit, don't export default, rework static class…
brian-mann Oct 23, 2019
2f00863
tighten up
brian-mann Oct 23, 2019
fe32e05
coffeescript fixes, consistent regexp const naming
brian-mann Oct 23, 2019
62d54d1
capitalize interface, tighten up several modifier functions
brian-mann Oct 23, 2019
cfc8a0d
misc cleanup and tightening up
brian-mann Oct 23, 2019
c389642
rework impl to use stubs instead of numbers
brian-mann Oct 23, 2019
5206167
some more cleanup
brian-mann Oct 23, 2019
d9a622a
fix logic with when function is called
brian-mann Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/driver/src/cy/actionability.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ verify = (cy, $el, options, callbacks) ->
visibility: true,
notDisabled: true,
notCovered: true,
notAnimating: true,
notReadonly: false,
custom: false
}
Expand Down Expand Up @@ -271,7 +272,7 @@ verify = (cy, $el, options, callbacks) ->

## if force is true OR waitForAnimations is false
## then do not perform these additional ensures...
if (force isnt true) and (options.waitForAnimations isnt false)
if (options.ensure.notAnimating) and (force isnt true) and (options.waitForAnimations isnt false)
## store the coords that were absolute
## from the window or from the viewport for sticky elements
## (see https://github.com/cypress-io/cypress/pull/1478)
Expand Down
Loading