Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: nanoid upgrade #31233

Merged
merged 2 commits into from
Mar 10, 2025
Merged

chore: nanoid upgrade #31233

merged 2 commits into from
Mar 10, 2025

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Mar 7, 2025

Additional details

Nothing really changed here in changelog that would have impacted nanoid usage for us: https://github.com/ai/nanoid/releases - we would have needed to change nanoid to a named import, but our code is already doing that.

Steps to test

How has the user experience changed?

PR Tasks

Copy link

cypress bot commented Mar 7, 2025

cypress    Run #60822

Run Properties:  status check passed Passed #60822  •  git commit 5158f3d79a: Merge branch 'develop' into nanoid-update
Project cypress
Branch Review nanoid-update
Run status status check passed Passed #60822
Run duration 11m 45s
Commit git commit 5158f3d79a: Merge branch 'develop' into nanoid-update
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 4
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 225
View all changes introduced in this branch ↗︎
UI Coverage  62.5%
  Untested elements 31  
  Tested elements 55  
Accessibility  96.22%
  Failed rules  0 critical   4 serious   1 moderate   0 minor
  Failed elements 195  

@jennifer-shehane jennifer-shehane self-assigned this Mar 10, 2025
@jennifer-shehane jennifer-shehane merged commit 5ff7e37 into develop Mar 10, 2025
91 of 92 checks passed
@jennifer-shehane jennifer-shehane deleted the nanoid-update branch March 10, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants