Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhance ts definitions for automation #31231

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

cacieprins
Copy link
Contributor

  • Closes

Additional details

In preparation for the tab key command, this is some type enhancements in automation. The command params/return values are still any, but there is structure for defining those types. As well, a dangling promise is now awaited, and a promise' .try() with no corresponding .catch() was converted to a try/catch that logs the exception to debug.

Steps to test

How has the user experience changed?

PR Tasks

@cacieprins cacieprins marked this pull request as ready for review March 7, 2025 16:08
Copy link

cypress bot commented Mar 7, 2025

cypress    Run #60828

Run Properties:  status check failed Failed #60828  •  git commit 32f47f9178: Merge branch 'develop' into cacie/refactor/automation-ts
Project cypress
Branch Review cacie/refactor/automation-ts
Run status status check failed Failed #60828
Run duration 16m 16s
Commit git commit 32f47f9178: Merge branch 'develop' into cacie/refactor/automation-ts
Committer Cacie Prins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 11
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 1109
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 21733
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  46.31%
  Untested elements 184  
  Tested elements 163  
Accessibility  92.56%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 876  

Tests for review

Failed  commands/aliasing.cy.ts • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts
Failed  commands/request.cy.js • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts
Failed  commands/waiting.cy.js • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts
Failed  commands/screenshot.cy.js • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts
Failed  cypress/cy.cy.js • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts

The first 5 failed specs are shown, see all 847 specs in Cypress Cloud.

Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
... > stops waiting when an xhr request is canceled
    </td>
  </tr></table>
Flakiness  e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
cy.origin - cookie login > Max-Age > past max-age -> not logged in Test Replay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants