-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: enhance ts definitions for automation #31231
Open
cacieprins
wants to merge
7
commits into
develop
Choose a base branch
from
cacie/refactor/automation-ts
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+73
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-shehane
approved these changes
Mar 7, 2025
AtofStryker
approved these changes
Mar 7, 2025
cypress
|
Project |
cypress
|
Branch Review |
cacie/refactor/automation-ts
|
Run status |
|
Run duration | 16m 16s |
Commit |
|
Committer | Cacie Prins |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
11
|
|
2
|
|
1109
|
|
0
|
|
21733
|
View all changes introduced in this branch ↗︎ |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
46.31%
|
|
---|---|
|
184
|
|
163
|
Accessibility
92.56%
|
|
---|---|
|
3 critical
8 serious
2 moderate
2 minor
|
|
876
|
Tests for review
The first 5 failed specs are shown, see all 847 specs in Cypress Cloud.
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
Test | Artifacts | |||||||
---|---|---|---|---|---|---|---|---|
... > stops waiting when an xhr request is canceled |
|
Test | Artifacts | |
---|---|---|
cy.origin - cookie login > Max-Age > past max-age -> not logged in |
Test Replay
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
In preparation for the tab key command, this is some type enhancements in automation. The command params/return values are still
any
, but there is structure for defining those types. As well, a dangling promise is now awaited, and a promise'.try()
with no corresponding.catch()
was converted to atry/catch
that logs the exception to debug.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?