misc: Move browser dropdown within AUT URL bar #31216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
browser-dropdown-ux-update
|
| Run status |
|
| Run duration | 18m 18s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
10
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32102
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.57%
|
|
|---|---|
|
Untested elements
|
182
|
|
Tested elements
|
163
|
Accessibility
92.57%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
885
|
…nt to work........
jennifer-shehane
commented
Mar 7, 2025
| @@ -151,7 +151,7 @@ describe('Cypress In Cypress E2E', { viewportWidth: 1500, defaultCommandTimeout: | |||
| }) | |||
|
|
|||
| it('shows a compilation error with a malformed spec', { viewportHeight: 596, viewportWidth: 1000 }, () => { | |||
| const expectedAutHeight = 456 // based on explicitly setting viewport in this test to 596 | |||
| const expectedAutHeight = 500 // based on explicitly setting viewport in this test to 596 | |||
There was a problem hiding this comment.
This has legitimately changed, previously the browser dropdown at this width was lessening the AUT height.
jennifer-shehane
commented
Mar 7, 2025
| @@ -128,7 +128,7 @@ export const longBrowsersList = [ | |||
| majorVersion: '69', | |||
There was a problem hiding this comment.
Not really necessary changes, but these mocks seem more realisitic
…eenshotting from breaking.
… to be above that also
| @@ -1,3 +1,4 @@ | |||
| <!-- Be careful with changing styles of the panels, it can impact our screenshot tests --> | |||
There was a problem hiding this comment.
lesson learned.......
…ss-io/cypress into browser-dropdown-ux-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
yarn cypress:openin thepackages/appdirectoryHow has the user experience changed?
Before
After
Automation Missing error did not change much
PR Tasks
cypress-documentation?type definitions?