misc: convert server/lib/modes files to ts + add more cli options to Cloud terminal error outputs #31211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-shehane
commented
Mar 3, 2025
| @@ -68,7 +68,7 @@ const toUploadReportPayload = (acc: { | |||
| type UploadArtifactOptions = { | |||
| protocolManager?: ProtocolManager | |||
| videoUploadUrl?: string | |||
| video?: string // filepath to the video artifact | |||
| video?: string | null // filepath to the video artifact | |||
There was a problem hiding this comment.
I saw where we set this null in another file, so this is possible
jennifer-shehane
commented
Mar 3, 2025
| const warning = (code, args) => { | ||
| const debug = Debug('cypress:server:cypress') | ||
|
|
||
| type Mode = 'exit' | 'info' | 'interactive' | 'pkg' | 'record' | 'results' | 'run' | 'smokeTest' | 'version' | 'returnPkg' | 'exitWithCode' |
There was a problem hiding this comment.
This type may be more than is actually supported. It was hard to tell the definitive list by how this is called.
jennifer-shehane
commented
Mar 3, 2025
Comment on lines
+102
to
+103
| parallel: `${parallel}`, | ||
| autoCancelAfterFailures: `${autoCancelAfterFailures}`, |
There was a problem hiding this comment.
These error messages only accept strings
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
js-to-ts-server-2
|
| Run status |
|
| Run duration | 18m 29s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
7
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32101
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.44%
|
|
|---|---|
|
Untested elements
|
183
|
|
Tested elements
|
163
|
Accessibility
92.55%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
877
|
jennifer-shehane
commented
Mar 4, 2025
| @@ -1397,7 +1398,6 @@ export const AllCypressErrors = { | |||
| https://on.cypress.io/test-retries | |||
| ` | |||
| }, | |||
| // TODO: test this | |||
There was a problem hiding this comment.
there is a test for this!
jennifer-shehane
changed the title
cacieprins
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?