breaking: remove CDP from firefox with Cypress 15 #31200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
force-pushed
the
breaking/remove_cdp_firefox
branch
from
b9fbe9b to
dff3dbf
Compare
AtofStryker
changed the title
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
breaking/remove_cdp_firefox
|
| Run status |
|
| Run duration | 18m 15s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
12
|
Pending
|
1099
|
Skipped
|
0
|
Passing
|
26543
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.15%
|
|
|---|---|
|
Untested elements
|
184
|
|
Tested elements
|
162
|
Accessibility
92.55%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
877
|
AtofStryker
force-pushed
the
breaking/remove_cdp_firefox
branch
from
dff3dbf to
07c5a8e
Compare
AtofStryker
changed the title
AtofStryker
force-pushed
the
breaking/remove_cdp_firefox
branch
from
07c5a8e to
52676da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
CDP will be removed with Firefox 141 see blogpost. Following Cypress last 3 major versions supported and relasing Cypress 15, it makes sense to remove CDP support within Firefox.
Since this could be a disruptive change to users using older versions of Firefox, we feel this is best to put this into a major version change, though it isn't technically a breaking change to the Cypress API
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation? chore: remove CDP deprecation notice cypress-documentation#6116type definitions?