Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: commit packages/graphql/schemas/schema.graphql from PR #29420 #29657

Merged

Conversation

MikeMcC399
Copy link
Contributor

Additional details

Steps to test

Execute:

git clean -xfd
yarn
git status

and confirm that there are no differences reported for packages/graphql/schemas/schema.graphql

How has the user experience changed?

This issue affects contributors only.

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@jennifer-shehane
Copy link
Member

@MikeMcC399 Please avoid merging develop if you can as it extends the time for us to merge in the PRs

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

I'll leave it to you then. I was just doing this because there were CI failures.

@jennifer-shehane jennifer-shehane merged commit dfec1e7 into cypress-io:develop Jun 12, 2024
67 checks passed
@MikeMcC399 MikeMcC399 deleted the issue-29656-schema-graphql branch June 12, 2024 16:28
@jennifer-shehane
Copy link
Member

@MikeMcC399 Yes I know. We can rerun failed only so it's a bit faster. No worries.

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Thank you for explaining! It would be good to add guidance to the Contributing document about what to do after PR submission, as it is not clear what external contributors should be doing exactly. Let me put this into a new issue to be clear about what questions need to be answered for optimal PR handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncommitted change to packages/graphql/schemas/schema.graphql after PR #29420
4 participants