fix: Add existential operators to properties before calling split in processBrowserPreRequest

[jennifer-shehane]

• Closes SIGABRT: Cannot read properties of undefined (reading 'split') | i.processBrowserPreRequest #28950

Additional details

Seems this was introduced in #28517

If these properties don't exist, they should no longer crash. It may result in null values for some of the properties we're trying to check to process service worker requests, but this seems better than outright crashing. Perhaps there's a better long term solution to ensure these exist before getting these values.

Steps to test

Good question. I have no idea why this would even be the case and don't see a clear way to unit test it.

How has the user experience changed?

Users should not see cypress crash with:

Cannot read properties of undefined (reading 'split')
TypeError: Cannot read properties of undefined (reading 'split')
    at <embedded>:4432:32336
    at Map.forEach (<anonymous>)
    at i.processBrowserPreRequest (<embedded>:4432:32254)
    at N.shouldIgnorePendingRequest (<embedded>:4432:42079)
    at N.addPendingBrowserPreRequest (<embedded>:4432:41117)
    at d (<embedded>:4432:40190)
    at _ (<embedded>:4432:36011)
    at _.emit (node:events:513:28)
    at f (<embedded>:4491:55225)
    at onEnd (<embedded>:4491:55769)
    at q (<embedded>:4491:53135)
    at N (<embedded>:4491:53761)
    at ee.<anonymous> (<embedded>:4491:55678)
    at ee.emit (node:events:525:35)
    at ee.onRequestError (<embedded>:2050:100575)
    at ClientRequest.emit (node:events:525:35)
    at Socket.socketErrorListener (node:_http_client:502:9)
    at Socket.emit (node:events:513:28)
    at emitErrorNT (node:internal/streams/destroy:151:8)
    at emitErrorCloseNT (node:internal/streams/destroy:116:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
GET /__cypress/runner/fonts/fa-solid-900.woff2 200 1.204 ms - 126828
The Test Runner unexpectedly exited via a exit event with signal SIGABRT

PR Tasks

• Have tests been added/updated?
• [N/A] Has a PR for user-facing changes been opened in cypress-documentation?
• [N/A] Have API changes been updated in the type definitions?

[cypress]

4 flaky tests on run #54047 ↗︎

0

5499

77

0

4

Details:

Merge branch 'develop' into processBrowserPreRequest-split-crash
Project: cypress	Commit: 6c54e8e4fa
Status: Passed	Duration: 17:48 💡
Started: Feb 15, 2024 5:53 PM	Ended: Feb 15, 2024 6:11 PM

  net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test		Artifacts
network stubbing > waiting and aliasing > yields the expected interception when two requests are raced		Test Replay

  querying/querying.cy.js • 1 flaky test • 5x-driver-chrome

View Output

Test		Artifacts
... > intercept aliases > returns the xhr		Test Replay

  waiting.cy.js • 1 flaky test • 5x-driver-chrome

View Output

Test		Artifacts
... > errors > throws when waiting for response to route		Test Replay

  files.cy.js • 1 flaky test • 5x-driver-chrome

View Output

Test		Artifacts
... > throws a specific error when file exists when it shouldn't		Test Replay

Review all test suite changes for PR #28952 ↗︎

[ryanthemanuel]

This is frustrating because according to the docs those are both required fields. Hmmm.

[ryanthemanuel]

I added the comments defaulting to '' as I think if they would have also crashed a couple of lines later. Looks good now though.

[MikeMcC399]

@this PR is already merged, however the changelog link is incorrect:

Fixed a regression introduced in [`13.6.3`](https://docs.cypress.io/guides/references/changelog#13.6.3) where Cypress could crash when processing service worker requests through our proxy. Fixes [#28950](https://github.com/cypress-io/cypress/issues/28950).

It should be

[`13.6.3`](https://docs.cypress.io/guides/references/changelog#13-6-3)

if 13.6.3 is going to work correctly.

• See PR docs: fix anchor link to changelog 13.6.3 #28957 for fix

[jennifer-shehane]

@MikeMcC399 Thanks Mike!

[cypress-bot]

Released in 13.6.5.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.5, please open a new issue.