Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: fix performance issue for service workers that don't handle requests #28900

Merged
merged 43 commits into from
Mar 5, 2024
Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
2458318
support non-intercepting service worker
mschile Feb 7, 2024
f672933
updates
mschile Feb 7, 2024
48c172f
updating circleci workflow [run ci]
mschile Feb 7, 2024
49bb9a2
adding tests
mschile Feb 8, 2024
7e6ca9d
skip firefox
mschile Feb 8, 2024
e653ae3
metadata update [run ci]
mschile Feb 8, 2024
9ee7158
updates [run ci]
mschile Feb 8, 2024
63fd190
updates [run ci]
mschile Feb 8, 2024
8f77740
update cache version [run ci]
mschile Feb 8, 2024
ade40a2
Update browser-cri-client.ts
ryanthemanuel Feb 8, 2024
54e07f5
fixing build [run ci]
mschile Feb 8, 2024
925fc1c
Merge branch 'develop' into mschile/service_worker
mschile Feb 8, 2024
5f1a94a
support removeEventListener and onfetch
mschile Feb 9, 2024
0a1bd10
move rewriter logic
mschile Feb 9, 2024
be98db7
updates
mschile Feb 9, 2024
04c923a
updates
mschile Feb 12, 2024
e52613d
updates
mschile Feb 13, 2024
5aed7ce
renaming
mschile Feb 13, 2024
c21d36f
updates
mschile Feb 15, 2024
9357ab4
updates
mschile Feb 15, 2024
d08dfae
updates
mschile Feb 16, 2024
490eeca
Update cli/CHANGELOG.md
mschile Feb 16, 2024
5257fc2
test updates
mschile Feb 19, 2024
97e0d10
renaming
mschile Feb 23, 2024
9b3cc3e
renaming
mschile Feb 23, 2024
8991660
updates
mschile Feb 23, 2024
d0d9b3c
Merge branch 'develop' into mschile/service_worker
mschile Feb 23, 2024
cb55162
fix references
mschile Feb 23, 2024
0639d02
adding queue
mschile Feb 26, 2024
2a7b32a
fixing unit test
mschile Feb 26, 2024
decc763
additional tests
mschile Feb 26, 2024
a5c864f
fixing typescript issue
mschile Feb 27, 2024
b0ddedb
updating unit test
mschile Feb 27, 2024
d9a876d
pr updates
mschile Feb 28, 2024
457687c
renaming
mschile Feb 28, 2024
8378c36
renaming
mschile Feb 28, 2024
5923bcf
Merge branch 'develop' into mschile/service_worker
mschile Feb 28, 2024
18629cf
ts updates
mschile Mar 4, 2024
d33e8b1
support async and when listener throws
mschile Mar 4, 2024
61cc17a
pr updates
mschile Mar 4, 2024
798f4ae
updating injector spec
mschile Mar 4, 2024
b074a9e
updating prerequests
mschile Mar 5, 2024
bba9f38
Merge branch 'develop' into mschile/service_worker
mschile Mar 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/cache-version.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Bump this version to force CI to re-create the cache from scratch.

01-04-24
02-08-24
16 changes: 5 additions & 11 deletions .circleci/workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@ mainBuildFilters: &mainBuildFilters
- develop
- /^release\/\d+\.\d+\.\d+$/
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- 'chore/update_octokit'
- 'publish-binary'
- 'em/circle2'
- 'update-v8-snapshot-cache-on-develop'

# usually we don't build Mac app - it takes a long time
# but sometimes we want to really confirm we are doing the right thing
Expand All @@ -42,8 +40,7 @@ macWorkflowFilters: &darwin-workflow-filters
- equal: [ develop, << pipeline.git.branch >> ]
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- equal: [ 'chore/update_octokit', << pipeline.git.branch >> ]
- equal: [ 'ryanm/fix/service-worker-capture', << pipeline.git.branch >> ]
- equal: [ 'mschile/service_worker', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand All @@ -54,8 +51,7 @@ linuxArm64WorkflowFilters: &linux-arm64-workflow-filters
- equal: [ develop, << pipeline.git.branch >> ]
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- equal: [ 'chore/update_octokit', << pipeline.git.branch >> ]
- equal: [ 'em/circle2', << pipeline.git.branch >> ]
- equal: [ 'mschile/service_worker', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand All @@ -78,9 +74,7 @@ windowsWorkflowFilters: &windows-workflow-filters
- equal: [ develop, << pipeline.git.branch >> ]
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- equal: [ 'chore/update_octokit', << pipeline.git.branch >> ]
- equal: [ 'lerna-optimize-tasks', << pipeline.git.branch >> ]
- equal: [ 'mschile/mochaEvents_win_sep', << pipeline.git.branch >> ]
- equal: [ 'mschile/service_worker', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand Down Expand Up @@ -150,7 +144,7 @@ commands:
name: Set environment variable to determine whether or not to persist artifacts
command: |
echo "Setting SHOULD_PERSIST_ARTIFACTS variable"
echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "publish-binary" && "$CIRCLE_BRANCH" != "chore/update_octokit" ]]; then
echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "mschile/service_worker" ]]; then
export SHOULD_PERSIST_ARTIFACTS=true
fi' >> "$BASH_ENV"
# You must run `setup_should_persist_artifacts` command and be using bash before running this command
Expand Down
4 changes: 4 additions & 0 deletions cli/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@

_Released 2/13/2024 (PENDING)_

**Performance:**

- Fixed a performance regression from [`13.6.4`](https://docs.cypress.io/guides/references/changelog#13-6-4) where unhandled service worker requests may not correlate correctly. Fixes [#28868](https://github.com/cypress-io/cypress/issues/28868).

**Bugfixes:**

- Fixed an issue which caused the browser to relaunch after closing the browser from the Launchpad. Fixes [#28852](https://github.com/cypress-io/cypress/issues/28852).
Expand Down
Loading