perf: improve performance when finding unique selectors for Test Replay #28536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
When finding unique selectors for snapshots in Test Replay, we currently use @cypress/unique-selector. However, this package tries to generate a more human-readable and reduced selector than what is needed for Test Replay and subsequently can cause performance issues. I am updating the snapshots to use the @medv/finder packages which has options to vastly improve performance. Observed finding unique selectors in some scenarios go from
~350ms
to~0.5ms
.Steps to test
How has the user experience changed?
Command log snapshots will be more performant.
PR Tasks
cypress-documentation
?type definitions
?