Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with 'other' targets not fully loading #28229

Merged
merged 9 commits into from
Nov 3, 2023

Conversation

ryanthemanuel
Copy link
Collaborator

@ryanthemanuel ryanthemanuel commented Nov 2, 2023

Additional details

other targets can't be Network.enable. We don't get an exception or anything, it just hangs out there. As a result we were never resuming those targets. We fix this by not Network.enableing them.

Steps to test

There's now a new system test for this scenario.

How has the user experience changed?

PDFs embedded object tags will fully load

PR Tasks

Copy link

cypress bot commented Nov 2, 2023

9 flaky tests on run #52107 ↗︎

0 9849 1022 0 Flakiness 9

Details:

Update system-tests/projects/e2e/cypress/e2e/other_target.cy.js
Project: cypress Commit: 0c60849922
Status: Passed Duration: 15:02 💡
Started: Nov 3, 2023 3:55 PM Ended: Nov 3, 2023 4:10 PM
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome

View Output Video

Test Artifacts
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output
Flakiness  commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output
... > with `times` > only uses each handler N times Output
... > stops waiting when an xhr request is canceled Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-webkit

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output

Review all test suite changes for PR #28229 ↗︎

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 8, 2023

Released in 13.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants