-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): Update Runs page visuals to new layout and card design #27770
Conversation
# Conflicts: # cli/CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! I left a few minor comments. The only one that I think really needs fixing is the "View runs in Cypress Cloud" button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for addressing my comments ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a PR (#27798) with changes to consider. Please take a look and validate if they make sense to include or not.
I wish there was a better way to accomplish the complexity with when and where the flaky badge is shown. Potentially pulling that part out of the RunResults
component and making it a separate component would help, but not going to ask for that now.
Overall, the changes are great! I just feel like there is no reason to truncate the branch name and duration/time ago information at the larger breakpoints when there will always be plenty of room.
The only other request I have is to write tests to validate the tooltip for the RunTags to validate they contain the right information at the different breakpoints.
One other thing that was not called out on the original issue but is in the designs is the updated "skeleton" loading states for the page. There are two versions (with and without git info). They are here: |
Updated with new skeletons. |
Added tooltip tests, merged changes down, looks solid! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skeletons worked out great. Left some suggestions for small improvements.
The tests for the tooltips on the RunTagCount allowed me to better see the styling there. Added some suggestions to get it to better match the designs.
Co-authored-by: Stokes Player <stokes@cypress.io>
Co-authored-by: Stokes Player <stokes@cypress.io>
Co-authored-by: Stokes Player <stokes@cypress.io>
Co-authored-by: Stokes Player <stokes@cypress.io>
Co-authored-by: Stokes Player <stokes@cypress.io>
Co-authored-by: Stokes Player <stokes@cypress.io>
Co-authored-by: Stokes Player <stokes@cypress.io>
Co-authored-by: Stokes Player <stokes@cypress.io>
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
RunsLayout
forRunsContainer
RunCard
toDebug
button that navigates to run on debug pageshowDebugForCloudRun
return type, should be boolean as it's navigational and no query data is returnedSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?