test: fix flaky tests #26505
Merged
test: fix flaky tests #26505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhenkes
approved these changes
Apr 14, 2023
9 flaky tests on run #45573 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Nuxt > error conditions |
Output
Screenshots
Video
|
|
| Angular 13 > error conditions |
Output
Screenshots
Video
|
|
cypress\e2e\specs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > shows No Specs page with specPattern from config |
Output
Screenshots
Video
|
|
cypress\e2e\create-from-component.cy.ts • 2 flaky tests • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > runs generated spec |
Output
Screenshots
Video
|
|
| ... > Shows create from component card for React projects |
Output
Screenshots
Video
|
|
cypress\e2e\runner\reporter.command_errors.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| errors ui > cy.readFile |
Output
Screenshots
Video
|
|
cypress\e2e\specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Output
Screenshots
Video
|
|
The first 5 flaky specs are shown, see all 7 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
lmiller1990
approved these changes
Apr 17, 2023
| @@ -302,15 +302,15 @@ describe('setupNodeEvents', () => { | |||
|
|
|||
| cy.findByRole('button', { name: 'Try again' }).click() | |||
| cy.get('[data-cy-testingType=e2e]').click() | |||
| cy.contains('h1', cy.i18n.launchpadErrors.generic.configErrorTitle) | |||
| cy.contains('h1', cy.i18n.launchpadErrors.generic.configErrorTitle, { timeout: 10000 }) | |||
There was a problem hiding this comment.
Probably would have just updated the entire suite:
describe('Config files error handling', { defaultCommandTimeout: 10000 }, () => {
But this works too 👍
astone123
approved these changes
Apr 17, 2023
astone123
added a commit
to kgroat/cypress
that referenced
this pull request
Apr 19, 2023
* test(launchpad): fix flaky tests Closes cypress-io#23153 Closes cypress-io#23154 --------- Co-authored-by: astone123 <adams@cypress.io>
tgriesser
added a commit
that referenced
this pull request
Apr 25, 2023
* feat/protocol: (45 commits) chore: adding support for url:changed (#26519) chore: adding viewport:changed to protocol (#26508) chore: Reduce dependencies and binary size, add circle ci detector (#26522) chore: 12.10.0 release (#26517) test: fix flaky tests (#26505) chore: Check project dependencies for CT compatibility (#26497) chore: update vm2 to 3.9.16 (#26489) chore: enable builds on feat/protocol branch (#26506) chore: [skip ci] update to labels looked at by stalebot (#26496) chore: connecting to electron browser (#26471) chore: [skip ci] turning on stale bot (#26488) chore: fix issue with logs without wallClockUpdatedAt (#26473) Update triage_add_to_project.yml chore: Update Chrome (stable) to 112.0.5615.49 and Chrome (beta) to 113.0.5672.24 (#26434) feat: display framework definition errors (#26183) fix: correctly resolve dependencies for CT onboarding when using Yarn Plug n Play (#26452) fix: Subscribe to framework detection changes in wizard (#26437) fix: make clicks on type('{enter}') composed (#26395) chore: update add-to-project workflow (#26439) chore: Pass telemetry resources from the node process to the browser (#26468) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code, but never found it. #23153, Flaky test: ENOENT: no such file or directory #23154Additional details
These changes make our e2e tests more resilient so that they aren't causing so much flake in our windows jobs.
Steps to test
yarn workspace @packages/launchpad cypress:openHow has the user experience changed?
PR Tasks
cypress-documentation?type definitions?