misc: remove New badge for debug page navigation icon
#25992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 flaky tests on run #44521 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
Video
|
|
| ... > correctly returns currentRetry |
Output
Video
|
|
| ... > correctly returns currentRetry |
Output
Video
|
|
create-from-component.cy.ts • 2 flaky tests • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > runs generated spec |
Output
Screenshots
Video
|
|
| ... > runs generated spec |
Output
Screenshots
Video
|
|
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Output
Screenshots
Video
|
|
cypress-in-cypress-component.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress In Cypress CT > default config > redirects to the specs list with error if a spec is not found |
Output
Screenshots
Video
|
|
cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution |
Output
Screenshots
Video
|
|
The first 5 flaky specs are shown, see all 12 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
1 task
astone123
requested review from
marktnoonan,
warrensplayer,
lmiller1990,
mike-plummer and
jordanpowell88
lmiller1990
approved these changes
Mar 2, 2023
warrensplayer
approved these changes
Mar 3, 2023
|
I was having trouble seeing new runs show up but it seems unrelated to this branch, will post confirmation shortly. |
marktnoonan
approved these changes
Mar 3, 2023
jordanpowell88
approved these changes
Mar 3, 2023
| @@ -178,18 +177,13 @@ watchEffect(() => { | |||
| return | |||
| } | |||
|
|
|||
| const showNewBadge = isAllowedFeature('debugNewBadge', loginConnectStore) | |||
| const newBadge: Badge = { value: t('sidebar.debug.new'), status: 'success', label: t('sidebar.debug.debugFeature') } | |||
|
|
|||
| if (props.gql?.currentProject?.cloudProject?.__typename === 'CloudProject' | |||
| && props.gql.currentProject.cloudProject.runByNumber | |||
| && props.online | |||
| ) { | |||
| const { status, totalFailed } = props.gql.currentProject.cloudProject.runByNumber || {} | |||
|
|
|||
| if (status === 'NOTESTS' || status === 'RUNNING') { | |||
There was a problem hiding this comment.
Do we need the empty if here?
There was a problem hiding this comment.
I think so, because otherwise we'll hit this code block for the NOTESTS and RUNNING statuses
setDebugBadge({ value: countToDisplay, status: 'error', label: errorLabel })
Which I don't think we want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR removes the "New" badge from the debug page navigation icon, both the full icon and the "dot" collapsed icon.
Steps to test
Open a project in Cypress and verify the following
How has the user experience changed?
See the Percy build
PR Tasks
cypress-documentation?type definitions?