-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve memory management for chromium-based browsers #25462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
mjhenkes
approved these changes
Jan 18, 2023
emilyrohrbough
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
experimentalMemoryManagement
flag to improve memory management in Chromium-based browsers.Additional details
Algorithm:
When the test run starts:
On a defined interval (e.g. 1s):
Before each test:
After the test run ends:
Since the manual GC is run before each test, if a single test consumes enough memory, it is still possible to reach an OOM scenario.
Steps to test
Run a spec that consumes enough memory to cause an OOM error and then turn on the experimental flag and verify the spec now passes.
How has the user experience changed?
Ran the following spec on Chromium 107 in run mode:
Before (OOM crash at test 85):

After (No OOM crash):

PR Tasks
cypress-documentation
?type definitions
?