Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Restrict dependency versions to known supported ranges #25380

Merged
merged 2 commits into from
Jan 10, 2023
Merged

fix: Restrict dependency versions to known supported ranges #25380

merged 2 commits into from
Jan 10, 2023

Conversation

mike-plummer
Copy link
Contributor

User facing changelog

  • Fixes issue where component tests could incorrectly treat new major versions of certain dependencies as supported

Additional details

Steps to test

No functional changes to current behavior, validate existing system tests pass

How has the user experience changed?

PR Tasks

  • [na] Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress
Copy link

cypress bot commented Jan 6, 2023 •
edited
Loading


Test summary

5033 • 0 • 75 • 0 • Flakiness 8

Run details
Project cypress
Status Passed
Commit ffa825d
Started Jan 6, 2023 7:06 PM
Ended Jan 6, 2023 7:20 PM
Duration 13:23 💡
OS Linux Debian -
Browser Electron 106

View run in Cypress Dashboard ➡️

Flakiness

cookie_behavior.cy.ts 4 Flakiness
1 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
2 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
3 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
4 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
commands/navigation.cy.ts 1 Flakiness
1 cy.origin navigation > #consoleProps > .go()
This comment includes only the first 5 flaky tests. See all 8 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mike-plummer mike-plummer requested a review from a team January 6, 2023 19:05
@mike-plummer mike-plummer requested a review from a team January 9, 2023 21:13
astone123
astone123 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@astone123 astone123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍🏻

@mike-plummer mike-plummer merged commit 6aca035 into develop Jan 10, 2023
@mike-plummer mike-plummer deleted the mikep/depdency-version-restrictions branch January 10, 2023 14:54
tgriesser added a commit that referenced this pull request Jan 18, 2023
@tgriesser
Merge branch 'develop' into tgriesser/spike/spike
3e305cd 
* develop: (45 commits)
  fix: re-enable CYPRESS_INTERNAL_VITE_DEV development (#25364)
  fix: add skip domain injection description (#25463)
  fix: revert CSP header and script-src addition (#25445)
  chore: Update v8 snapshot cache (#25401)
  feat: Do not strip CSP headers from HTTPResponse (#24760)
  fix: keep spaces in formatted output in test runner (#24687)
  fix: Restrict dependency versions to known supported ranges (#25380)
  chore: Update v8 snapshot cache (#25370)
  feat: experimental skip domain injection (#25307)
  chore: support vite v4 for component testing (#25365)
  feat: Use JSX/TSX in generated spec filenames (#25318)
  docs(angular): Properties that are spied upon have to be defined within `componentProperties` instead of on root level. (#25359)
  chore: remove lint-changed from scripts/docs (#25308)
  chore: bump to 12.3.0 [skip ci] (#25355)
  fix: make NODE_ENV "production" for prod builds of launchpad (#25320)
  fix: .contains() should only return one element at all times (#25250)
  feat: add currentRetry to Cypress API (#25297)
  chore: release @cypress/webpack-dev-server-v3.2.2
  chore: release create-cypress-tests-v2.0.1
  fix: change wording for spec creation (#25271)
  ...
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 24, 2023

Released in 12.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@astone123 astone123 astone123 approved these changes

@ZachJW34 ZachJW34 ZachJW34 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unbounded ranges from CT dependency version checks
3 participants
@mike-plummer @astone123 @ZachJW34