-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only render debug artifacts when info is available #25362
Conversation
@@ -52,7 +52,7 @@ | |||
|
|||
<script setup lang="ts"> | |||
import { gql } from '@urql/vue' | |||
import { computed } from '@vue/reactivity' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw this in a few files, thought I'd fix them all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. Just added one suggestion.
Going to merge, CI failed due to a flaky test and I've created an issue + PR for skipping it: #25378 |
User facing changelog
n/a - Feature branch
Additional details
Only render debug artifacts if the corresponding
has<attr>
is true and the<attr>Url
is defined.Steps to test
video: false
to the cypress configCYPRESS_INTERNAL_ENV=development npx cypress run --record --key <RECORD_KEY>
DebugContainer.vue
and changerunByNumber(runNumber: <RUN_NUMBER>)
, the last step should have recorded a run to your locally running dashboard and you can find the run number thereYou can disable screenshots if you like and record another run.
How has the user experience changed?
Screen.Recording.2023-01-04.at.2.32.51.PM.mov
PR Tasks
cypress-documentation
?type definitions
?