-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add messaging for retention state exceeded #25361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Only two minor updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits, going to approve assuming that @warrensplayer comment on the isHidden
will be addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
User facing changelog
No changelog entry, merging to feature branch
Additional details
Adding handling for new "Data Retention" messaging state when an OVERLIMIT is reported. Extending messaging for "usage" overlimits by adding test recording limit value to message.
See #25352 for details
Steps to test
See
DebugRunStates.cy.tsx
for new states, Percy snapshots generated for all four permutations (Retention User, Retention Admin, Usage User, Usage Admin)How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?