feat: IATR-M0 Page Header (#24722) #25360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||||||
mike-plummer
approved these changes
Jan 5, 2023
warrensplayer
requested changes
Jan 5, 2023
| @@ -197,6 +197,9 @@ describe('<DebugFailedTest/>', () => { | |||
|
|
|||
| assertRowContents(testResult) | |||
|
|
|||
| cy.contains('...').realHover() | |||
| cy.contains('[data-cy=tooltip-content]', 'Test content 2').should('be.visible') | |||
There was a problem hiding this comment.
This should contain everything that was hidden by the ellipsis separated by >
Suggested change
| cy.contains('[data-cy=tooltip-content]', 'Test content 2').should('be.visible') | |
| cy.contains('[data-cy=tooltip-content]', 'Test content 2 > Test content 3 > Test content 4').should('be.visible') |
| @@ -30,7 +30,17 @@ | |||
| titlePart.type === 'LAST-1' ? 'shrink-0 whitespace-pre' : | |||
| titlePart.type === 'LAST-0' ? 'pl-2.5 truncate' : 'px-2.5 truncate'" | |||
| > | |||
| {{ titlePart.title }} | |||
| <template v-if="titlePart.title === '...'"> | |||
There was a problem hiding this comment.
Suggested change
| <template v-if="titlePart.title === '...'"> | |
| <template v-if="titlePart.type === 'ELLIPSIS'"> |
Check with type instead of title
| @@ -121,6 +133,7 @@ const failedTestData = computed(() => { | |||
| { | |||
| title: '...', | |||
| type: 'ELLIPSIS', | |||
| originalTitle: ele, | |||
There was a problem hiding this comment.
This will need to gather up all the "MIDDLE" parts to construct the originalTitle passed to the ELLIPSIS tooltip
There was a problem hiding this comment.
That makes sense, thanks! I think I was missing the underlying concept here, that it's really combining the parts 👍
warrensplayer
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
NA, merging to feature branch
Additional details
Added an optional
originalTitleproperty to theMappedTitleParttype. There are numerous other ways to handle this but this one seems fine to me. We could maybe work on the readability of this component at a future time.Steps to test
Visit the component test for
DebugFailedTest.vueand let it run. Observe tooltip appears when you hover over the ellipses:Sections that are truncated by ellipses, but still visible, will not have this tooltip, based on the wording of the original issue. To do that we would need a little more sophisticated approached to determine that the browser has truncated the text and conditionally enable the tooltip, the presence of the class alone is not enough. So that is out of scope for this ticket.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?