-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: IATR-M1.0 Debug page Header Update #25072
feat: IATR-M1.0 Debug page Header Update #25072
Conversation
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏻 I left some minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. I'm definitely interested in making things as type safe as possible, but not obvious issues with the implementation.
packages/app/package.json
Outdated
@@ -21,6 +21,7 @@ | |||
"dependencies": {}, | |||
"devDependencies": { | |||
"@cypress-design/vue-icon": "^0.12.1", | |||
"@cypress-design/vue-statusicon": "0.1.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really your wheelhouse, but I wonder why they don't just publish a single package, cypress-design/core
, with everything we need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmiller1990 That is because of versioning.
Upgrading a package should not risk breaking the rest of the platform.
It is a way of minimizing the surface risk while still mutualizing the components.
We might create a @cypress-design/core
at some point once it stabilizes.
User facing changelog
This PR aims to update the Debug Page Header to provide more information. It accomplishes the following:
run Number
from the first row so that the "commits Ahead" message is the only element visible in the top section.run status
component in the bottom section. This section contains astatus icon
and therun number
with matching colors depending on the status returned from the cloud. This takes into account all current run statuses (Passed, Failed, Errored, Cancelled, Running)status icon
andstatus name
from the test countsflaky badge
which comprises of the total flaky tests number and the "Flaky" text separated by a vertical border. This is only visible when the total number of flaky tests is > 0 and the value is not nullAdditional details
debugPageHeader.vue
. The design for the run status requires matching colors for the text (run number) and icon. In order to render a specific color depending on the status I have created a simple mapping for each possible status and the respective colorSteps to test
This issue has 2 component tests. Checkout to this branch to run the tests
Both
DebugPageHeader.vue
andDebugResults.vue
exist in thepackages/app/
folder. To run these tests:packages/app
yarn dev
DebugPageHeader.cy.tsx
andDebugResults.cy.tsx
How has the user experience changed?
Updated Page Header:

Old Page Header:

PR Tasks
cypress-documentation
?type definitions
?