chore: fix test and types in server #23693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
lmiller1990
commented
Sep 7, 2022
| @@ -166,7 +166,7 @@ export function launch ( | |||
| debuggingPort: number, | |||
| args: string[] = [], | |||
| defaultBrowserEnv = {}, | |||
| ): LaunchedBrowser { | |||
There was a problem hiding this comment.
Return value is implicit
lmiller1990
commented
Sep 7, 2022
| @@ -561,7 +561,7 @@ export async function open (browser: Browser, url: string, options: BrowserLaunc | |||
|
|
|||
| debug('closing firefox') | |||
|
|
|||
| originalBrowserKill.apply(browserInstance, args) | |||
| return originalBrowserKill.apply(browserInstance, args) | |||
There was a problem hiding this comment.
Needed to return this so the overridden kill has the correct signature (needs a return value of boolean)
2 tasks
lmiller1990
commented
Sep 7, 2022
| @@ -531,12 +531,12 @@ export async function open (browser: Browser, url: string, options: BrowserLaunc | |||
|
|
|||
| debug('launch in firefox', { url, args: launchOptions.args }) | |||
|
|
|||
| const browserInstance = await launch(browser, 'about:blank', remotePort, launchOptions.args, { | |||
There was a problem hiding this comment.
it's not async, but we thought it was due to an incorrect stub:
In this case the erroneously stubbed value in the unit test was leading us to write incorrect code.
lmiller1990
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
BlueWinds
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up https://github.com/cypress-io/cypress/pull/23579/files#r963726642