-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular): angular mount #22858
feat(angular): angular mount #22858
Changes from all commits
1bec790
7f5c67a
4951e9b
ca7c8fa
255c5d6
1bff85d
8224cdf
ebbea48
9fc4850
25dbdad
c7a3dfe
814791b
86e8e83
c42c939
b54eac5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,7 +38,10 @@ | |
"./mocha/*", | ||
"./minimatch/*", | ||
"./sinon/**/*", | ||
"./sinon-chai/*" | ||
"./sinon-chai/*", | ||
// Copied from net-stubbing and renamed to a declaration file. Since it's not originally | ||
// a declaration file, we need to exclude it from linting. | ||
"./net-stubbing.d.ts" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed #22417 as a part of this work. Angular crawls all of the imported types and emits warnings due to this file not being included in the compilation. |
||
] | ||
} | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,43 +1,17 @@ | ||
{ | ||
"plugins": [ | ||
"cypress", | ||
"@cypress/dev", | ||
"@angular-eslint/eslint-plugin" | ||
"cypress" | ||
], | ||
"extends": [ | ||
"plugin:@cypress/dev/general", | ||
"plugin:@cypress/dev/tests" | ||
], | ||
"parser": "@typescript-eslint/parser", | ||
"env": { | ||
"cypress/globals": true | ||
}, | ||
"root": true, | ||
"globals": { | ||
"jest": "readonly" | ||
}, | ||
"rules": { | ||
"no-console": "off", | ||
"mocha/no-global-tests": "off", | ||
"no-useless-constructor": "off", | ||
"@typescript-eslint/no-useless-constructor": "off", | ||
"no-unused-vars": "off", | ||
"no-console": "off", | ||
"@typescript-eslint/no-unused-vars": "off" | ||
}, | ||
"overrides": [ | ||
{ | ||
"files": [ | ||
"lib/*", | ||
"src/*" | ||
] | ||
}, | ||
{ | ||
"files": [ | ||
"**/*.json" | ||
], | ||
"rules": { | ||
"quotes": "off", | ||
"comma-dangle": "off" | ||
} | ||
} | ||
] | ||
} | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
examples | ||
src | ||
cypress |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
module.exports = { | ||
...require('../../.releaserc.base'), | ||
branches: [ | ||
{ name: 'master', channel: 'latest' }, | ||
], | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No tests for
npm/angular
. To test this, we would need to install all of the webpack deps for Angular so all of the mounting tests are found in thesystem-tests/project-fixtures/angular/src/app/mount.cy.ts
which are run innpm-webpack-dev-server
e2e tests.