test: run app e2e tests in Windows CI #19979

flotwig · 2022-01-31T16:37:03Z

Closes UNIFY-1001

User facing changelog

Additional details

Adds windows-run-app-integration-tests-chrome with all app tests now passing on Windows.
- Passing: https://circleci.com/gh/cypress-io/cypress/1208860?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
Fix failures in app e2e spec
See if there is a better way to get googlechrome installed than running choco every time
- Unfortunately doesn't seem like it. The only way to get software preinstalled is to bring our own Windows runners: https://discuss.circleci.com/t/is-it-possible-to-customize-circlecis-windows-server-image/39914/2?u=flotwig We could use caching at least, but that would probably be even slower than the choco install.
Updated CreateSpecModal.vue to show backslashed initial spec filename on Windows.
Updated example-kitchensink to be the version with the latest expected scaffold.

How has the user experience changed?

PR Tasks

Have tests been added/updated?
[na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
[na] Has a PR for user-facing changes been opened in cypress-documentation?
[na] Have API changes been updated in the type definitions?
[na] Have new configuration options been added to the cypress.schema.json?

cypress-bot · 2022-01-31T16:37:07Z

Thanks for taking the time to open a PR!

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

cypress · 2022-01-31T16:54:07Z

Test summary

8726 • 1 • 105 • 0 • 1

Run details


Project	cypress
Status	Failed
Commit	`bb1f891`
Started	Feb 7, 2022 5:38 PM
Ended	Feb 7, 2022 5:50 PM
Duration	12:15 💡
OS	Linux Debian - 10.10
Browser	Multiple

View run in Cypress Dashboard ➡️

Failures

	cypress/e2e/commands/net_stubbing.cy.ts		1
1	network stubbing > intercepting request > should delay the same amount on every response

Flakiness

	cypress/e2e/commands/net_stubbing.cy.ts		1
1	network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

…ndows-app-e2e-tests

flotwig · 2022-02-03T17:09:06Z

packages/app/cypress/e2e/settings.cy.ts

+
+      expect(browsers).to.have.length.greaterThan(1)
+
+      // TODO: is this really how this is supposed to look?


Opened a Jira ticket for this: https://cypress-io.atlassian.net/browse/UNIFY-1026

Suggested change

// TODO: is this really how this is supposed to look?

ryanthemanuel · 2022-02-04T17:06:08Z

yarn.lock

@@ -17162,9 +17162,9 @@ cyclist@^1.0.1:
  resolved "https://registry.yarnpkg.com/cyclist/-/cyclist-1.0.1.tgz#596e9698fd0c80e12038c2b82d6eb1b35b6224d9"
  integrity sha1-WW6WmP0MgOEgOMK4LW6xs1tiJNk=

-cypress-example-kitchensink@cypress-io/cypress-example-kitchensink#feat/use-supportFiles:
+cypress-example-kitchensink@cypress-io/cypress-example-kitchensink#8389bb6b09c59c2720ceeaadecc8eaa2d4d6551d:


I don't think this is necessary anymore. 10.0-release and my branch are now passing without it.

The packages/example build scripts are not compatible with Windows, so using the pre-renamed files available in this commit actually are necessary for Windows.

ryanthemanuel · 2022-02-04T17:15:02Z

packages/app/cypress/e2e/index.cy.ts

@@ -1,5 +1,19 @@
 import defaultMessages from '@packages/frontend-shared/src/locales/en-US.json'

+function getPathForPlatform (posixPath: string) {


Could we import this?

import { getPathForPlatform } from '../../src/paths'

I purposely duplicated this logic so a regression in src/paths wouldn't cause the tests to erroneously pass by virtue of changing the expectation of the tests. I figure it's worth the duplication it to ensure the expectations of this spec are kept constant.

this is path.normalize()...

ryanthemanuel · 2022-02-04T17:15:27Z

packages/app/cypress/e2e/index.cy.ts

+  return posixPath
+}
+
+function getRunnerHref (specPath: string) {


Could we move this to src/paths like above in case it's needed in the future?

…ndows-app-e2e-tests

elevatebart · 2022-02-07T16:26:09Z

packages/app/src/paths.ts

+export function getPathForPlatform (posixPath: string) {
+  if (Cypress.platform === 'win32') return posixPath.replaceAll('/', '\\')
+
+  return posixPath
+}


this looks like path.normalize() https://nodejs.org/api/path.html#pathnormalizepath

true, we could use that instead

oh right, i don't think we have path here since it's on the client-side

elevatebart

Once you replace the function with path.normalize() I will approve

elevatebart

We have to avoid resolving/building paths in the browser but this is how it was done until now so we should do this refactoring in another story.

https://cypress-io.atlassian.net/browse/UNIFY-1051

flotwig changed the base branch from develop to 10.0-release January 31, 2022 16:37

flotwig mentioned this pull request Jan 31, 2022

fix: pass correct spec URL in cypress run on Windows #19890

Merged

jennifer-shehane assigned flotwig Jan 31, 2022

flotwig force-pushed the unify-1001-windows-app-e2e-tests branch from 2abfe9d to aa51f8a Compare January 31, 2022 17:54

flotwig added 4 commits February 2, 2022 17:04

Add windows-run-app-integration-tests-chrome

280d889

Install googlechrome on CI using choco

2e5344c

Build on this branch

02bf215

Update CreateSpecModal to use platform-specific paths

48be4ca

flotwig force-pushed the unify-1001-windows-app-e2e-tests branch from 063ce64 to 48be4ca Compare February 2, 2022 17:07

flotwig and others added 13 commits February 2, 2022 17:19

Merge remote-tracking branch 'origin/10.0-release' into unify-1001-wi…

1493466

…ndows-app-e2e-tests

Test with getPathForPlatform

f2b90d6

Fix withctx usage

c77442b

Use latest 10.0 example-kitchensink, remove build script

dc5b347

Fix expectedScaffoldPaths

5368965

Fix runner href tests

6f8d508

Fix settings.cy.ts

ca666c8

Fix runs.cy.ts hanging when browser disconnects

da16fdf

Fix "displays each run with correct information"

6690961

Fix LoginModal.cy.tsx

5670fcf

Fix create-cypress-tests

e2f0a66

Fix sidebar_navigation

163d48e

Merge branch '10.0-release' into unify-1001-windows-app-e2e-tests

5c88187

flotwig commented Feb 3, 2022

View reviewed changes

Update packages/app/cypress/e2e/settings.cy.ts

aed0b46

flotwig marked this pull request as ready for review February 3, 2022 18:46

flotwig requested a review from elevatebart February 3, 2022 18:46

mjhenkes requested a review from ryanthemanuel February 3, 2022 19:05

ryanthemanuel reviewed Feb 4, 2022

View reviewed changes

ryanthemanuel previously approved these changes Feb 5, 2022

View reviewed changes

Merge remote-tracking branch 'origin/10.0-release' into unify-1001-wi…

c24ac8c

…ndows-app-e2e-tests

flotwig dismissed ryanthemanuel’s stale review via c24ac8c February 7, 2022 15:36

elevatebart reviewed Feb 7, 2022

View reviewed changes

elevatebart suggested changes Feb 7, 2022

View reviewed changes

flotwig requested a review from ryanthemanuel February 7, 2022 16:29

flotwig mentioned this pull request Feb 7, 2022

Unification: Windows testing #19658

Closed

elevatebart previously approved these changes Feb 7, 2022

View reviewed changes

Add platform to percy_parallel_nonce

bb1f891

flotwig dismissed elevatebart’s stale review via bb1f891 February 7, 2022 16:48

elevatebart approved these changes Feb 7, 2022

View reviewed changes

flotwig merged commit 83ffb07 into 10.0-release Feb 7, 2022

flotwig deleted the unify-1001-windows-app-e2e-tests branch February 7, 2022 18:33

sync-by-unito bot mentioned this pull request May 30, 2022

Refactor: avoid creating file paths on the browser #21716

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: run app e2e tests in Windows CI #19979

test: run app e2e tests in Windows CI #19979

flotwig commented Jan 31, 2022 •

edited

Loading

cypress-bot bot commented Jan 31, 2022

cypress bot commented Jan 31, 2022 •

edited

Loading

flotwig Feb 3, 2022

ryanthemanuel Feb 4, 2022

flotwig Feb 4, 2022

ryanthemanuel Feb 4, 2022

flotwig Feb 4, 2022

elevatebart Feb 7, 2022

ryanthemanuel Feb 4, 2022

elevatebart Feb 7, 2022

flotwig Feb 7, 2022

flotwig Feb 7, 2022

elevatebart left a comment

elevatebart left a comment


		expect(browsers).to.have.length.greaterThan(1)

		// TODO: is this really how this is supposed to look?

		@@ -1,5 +1,19 @@
		import defaultMessages from '@packages/frontend-shared/src/locales/en-US.json'

		function getPathForPlatform (posixPath: string) {

test: run app e2e tests in Windows CI #19979

test: run app e2e tests in Windows CI #19979

Conversation

flotwig commented Jan 31, 2022 • edited Loading

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

cypress-bot bot commented Jan 31, 2022

cypress bot commented Jan 31, 2022 • edited Loading

Test summary

Run details

Failures

Flakiness

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elevatebart left a comment

Choose a reason for hiding this comment

elevatebart left a comment

Choose a reason for hiding this comment

flotwig commented Jan 31, 2022 •

edited

Loading

cypress bot commented Jan 31, 2022 •

edited

Loading