feat(app): decouple event manager from driver #18695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||||||
lmiller1990
commented
Oct 29, 2021
| @@ -78,8 +78,10 @@ | |||
| "@urql/exchange-execute", | |||
| "@urql/vue", | |||
| "@vueuse/core", | |||
| "bluebird", | |||
There was a problem hiding this comment.
Probably don't want to bundle bluebird here, but grab it from the webpack bundle 🤔 so we don't bundle it twice.
Can look into this, not a big deal right now, since lots more work to come around minimizing the use the webpack bundle.
lmiller1990
requested review from
jennifer-shehane,
brian-mann and
a team
and removed request for
a team and
jennifer-shehane
lmiller1990
commented
Oct 29, 2021
| } | ||
|
|
||
| // Stub AutIframe, useful for component testing | ||
| export const createTestAutIframe = (eventManager = createEventManager()) => { |
There was a problem hiding this comment.
These are just glorified stubs, but useful for component tests.
|
Pair reviewed w/ Zach W, talked with Brian about it, gonna merge this up and keep going. |
tgriesser
added a commit
that referenced
this pull request
Nov 4, 2021
…ve-activeProject * unified-desktop-gui: (57 commits) chore: Add e2e tests for global mode (#18719) chore: add percy to app and launchpad package (#18781) chore: update test refactor: move settings in app (#18729) feat: setup launchpad lifecycle (#18734) feat(app): decouple event manager from driver (#18695) chore: Force single resolution for core modules, infinite loop guard (#18764) fix(driver): Sticky elements within a fixed container will not prevent an element from being scrolled to (#18441) chore: cleaning up the runner container pattern (#18741) feat: Use .config files (#18578) chore(app): basic style and example to stop scrollIntoView bug (#18736) chore: make `create` function on server.ts obsolete (#18615) feat: add codegen utility (#18708) docs: Add instructions to squash commits to develop in Contributing (#18728) fix(@cypress/react): throw if using Next.js swc-loader without nodeVersion=system (#18686) refactor: remove Ramda (#18723) fix: support using create-cypress-tests as part of build process (#18714) chore: Increase paralleled machines for desktop-gui tests (#18725) fix(app): do not cache graphql (#18716) chore: Update Chrome (stable) to 95.0.4638.69 (#18696) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eventManagerinto a class instead of an objectEventManagerat the top of the runner, pass down as props (avoid global singleton import)appdirectory, import back torunnerandrunner-sharedThis one is probably best to pair code review on. I will write up more reviewing notes and points of interest once CI is green.
Jira: https://cypress-io.atlassian.net/browse/UNIFY-511
TODO before moving out of draft:
ts-check. It's failing, most likely because I am importingsocketinEventManager, and this is spreadingapp's strict TS config to the older, less type safe packages.