chore: skip or fix flaky tests (#23167)

Author: Rachel

.percy.yml

@@ -4,4 +4,4 @@ snapshot:
     - 1280
   min-height: 1024
 discovery:
-  network-idle-timeout: 1000
+  network-idle-timeout: 750

circle.yml

@@ -27,6 +27,8 @@ mainBuildFilters: &mainBuildFilters
     branches:
       only:
         - develop
+        - reapply-state-refactor
+        - fix-or-skip-flaky-tests
 
 # usually we don't build Mac app - it takes a long time
 # but sometimes we want to really confirm we are doing the right thing
@@ -63,7 +65,8 @@ windowsWorkflowFilters: &windows-workflow-filters
     or:
     - equal: [ develop, << pipeline.git.branch >> ]
     - equal: [ linux-arm64, << pipeline.git.branch >> ]
-    - equal: [ 'tbiethman/22272-globbing-working-dir', << pipeline.git.branch >> ]
+    - equal: [ 'fix-or-skip-flaky-tests', << pipeline.git.branch >> ]
+    - equal: [ 'lmiller/windows-vite-fix', << pipeline.git.branch >> ]
     - matches:
           pattern: "-release$"
           value: << pipeline.git.branch >>

package.json

@@ -90,7 +90,7 @@
     "@graphql-tools/wrap": "8.1.1",
     "@octokit/auth-app": "3.6.1",
     "@octokit/core": "3.6.0",
-    "@percy/cli": "1.1.0",
+    "@percy/cli": "1.2.0",
     "@percy/cypress": "^3.1.1",
     "@semantic-release/changelog": "5.0.1",
     "@semantic-release/git": "9.0.0",

packages/app/.percy.yml

@@ -4,4 +4,4 @@ snapshot:
     - 1280
   min-height: 1024
 discovery:
-  network-idle-timeout: 1000
+  network-idle-timeout: 750

packages/app/cypress/e2e/cypress-in-cypress-component.cy.ts

@@ -78,7 +78,8 @@ describe('Cypress In Cypress CT', { viewportWidth: 1500, defaultCommandTimeout:
       cy.get('[data-model-state="passed"]').should('contain', 'renders the test component')
     })
 
-    it('redirects to the specs list with error if a spec is not found', () => {
+    // TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23159
+    it.skip('redirects to the specs list with error if a spec is not found', () => {
       cy.visitApp()
       const { title, intro, explainer } = defaultMessages.specPage.noSpecError
       const badFilePath = 'src/DoesNotExist.spec.js'

packages/app/cypress/e2e/cypress-in-cypress-run-mode.cy.ts

@@ -33,7 +33,8 @@ describe('Cypress In Cypress - run mode', { viewportWidth: 1200 }, () => {
     cy.percySnapshot()
   })
 
-  it('component testing run mode spec runner header is correct', () => {
+  // TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23306
+  it.skip('component testing run mode spec runner header is correct', () => {
     cy.scaffoldProject('cypress-in-cypress')
     cy.findBrowsers()
     cy.openProject('cypress-in-cypress')

packages/app/cypress/e2e/specs_list_e2e.cy.ts

@@ -237,7 +237,8 @@ describe('App: Spec List (E2E)', () => {
         cy.get('button').contains('23 Matches')
       })
 
-      it('saves the filter when navigating to a spec and back', function () {
+      // TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23305
+      it.skip('saves the filter when navigating to a spec and back', function () {
         const targetSpecFile = 'accounts_list.spec.js'
 
         clearSearchAndType(targetSpecFile)

packages/app/cypress/e2e/support/execute-spec.ts

@@ -29,7 +29,7 @@ export const waitForSpecToFinish = (expectedResults) => {
   cy.get('.failed > .num').should('contain', '--')
 
   // Then ensure the tests are running
-  cy.contains('Your tests are loading...').should('not.exist')
+  cy.contains('Your tests are loading...', { timeout: 10000 }).should('not.exist')
 
   // Then ensure the tests have finished
   cy.get('[aria-label="Rerun all tests"]', { timeout: 30000 })

packages/data-context/test/unit/sources/GitDataSource.spec.ts

@@ -43,7 +43,8 @@ describe('GitDataSource', () => {
     sinon.restore()
   })
 
-  it(`gets correct status for files on ${os.platform()}`, async () => {
+  // TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23317
+  it.skip(`gets correct status for files on ${os.platform()}`, async () => {
     const onBranchChange = sinon.stub()
     const onGitInfoChange = sinon.stub()
     const onError = sinon.stub()

packages/driver/cypress/e2e/commands/actions/select.cy.js

@@ -146,7 +146,8 @@ describe('src/cy/commands/actions/select', () => {
       cy.get('#select-maps').select('de_train')
     })
 
-    it('can forcibly click even when being covered by another element', (done) => {
+    // TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23156
+    it.skip('can forcibly click even when being covered by another element', (done) => {
       const select = $('<select><option>foo</option></select>').attr('id', 'select-covered-in-span').prependTo(cy.$$('body'))
 
       $('<span>span on select</span>').css({ position: 'absolute', left: select.offset().left, top: select.offset().top, padding: 5, display: 'inline-block', backgroundColor: 'yellow' }).prependTo(cy.$$('body'))
@@ -173,7 +174,8 @@ describe('src/cy/commands/actions/select', () => {
       cy.get('#select-covered-in-span').select('foobar', { timeout: 1000, interval: 60 })
     })
 
-    it('can forcibly click even when element is invisible', (done) => {
+    // TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23157
+    it.skip('can forcibly click even when element is invisible', (done) => {
       const select = cy.$$('#select-maps').hide()
 
       select.click(() => {