Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 12.4.0 #4997

Merged
merged 25 commits into from
Jan 24, 2023
Merged

Release 12.4.0 #4997

merged 25 commits into from
Jan 24, 2023

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Jan 24, 2023

Adds the documentation for experimentalMemoryManagement and experimentalSkipDomainInjection for 12.4.0

adds the 12.4.0 changelog

AtofStryker and others added 3 commits January 9, 2023 15:18
* chore: add documentation for new experimentalUseDefaultDocumentDomain option

* chore: give more in depth look at experiment and why it is necessary

* chore: address comments from code review

* move disabling document.domain disclaimer up to discussion of injection

* chore: rework the experiment section

* chore: apply suggestions from code review
@vercel
Copy link

vercel bot commented Jan 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cypress-documentation ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 24, 2023 at 8:24PM (UTC)

- Documentation for `createOutputSpy` inside Angular component testing has been
corrected to reference the property inside `componentProperties`. Addressed in
[#25359](https://github.com/cypress-io/cypress/pull/25359)
- Vite 4+ will no longer show a warning when used for component testing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like a feature for adding official support for vite 4.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I would phrase it as Official support for Vite 4 projects for component testing. I would drop the + as we don't support anything past v4.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved as a feature with that phrasing in 4ba7d03

Copy link
Member

@emilyrohrbough emilyrohrbough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AtofStryker Check out the Writing the Changelog Guide. We need to link to issues when possible and list entries in order of importance.

- Added new `experimentalSkipDomainInjection` flag to disable Cypress from
setting `document.domain` on injection. Addressed in
[#25307](https://github.com/cypress-io/cypress/pull/25307).
- Added new `experimentalMemoryManagement` flag to improve memory management in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to experiment. Also need likely need to add a link to a Github discussion around this...Lets check with the team.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in 4ba7d03. Do we usually include a github discussion in the changelog?

@@ -0,0 +1,13 @@
<Alert type="warning">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these old alerts won't work. Replace this with an :::caution admonition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have this fixed in 74416b6. Does everything look right on your end?


- Added new
[`experimentalSkipDomainInjection`](/guides/references/experiments#Experimental-Skip-Domain-Injection)
flag to disable Cypress from setting `document.domain` on injection. Addresses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should expand on what issue experiment is addressing? Also this is an e2e only config right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is only an e2e config. I can add some details

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added more details and defined as e2e only in 2a4b1b2

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
- [`.as`](/api/commands/as) now accepts an options argument, allowing an alias
to be stored as a "query" or "static" value. Addresses
[#25173](https://github.com/cypress-io/cypress/issues/25173).
- Added official support for Vite 4 projects for component testing. Addresses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd list Vite support first, followed by the memory experiment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reordered in 2a4b1b2. How does that look?

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants