-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: add experimentalSkipDomainInjection option #4955
Merged
AtofStryker
merged 10 commits into
release-12.4.0
from
feature/experimentalUseDefaultDocumentDomain
Jan 9, 2023
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
09e859c
chore: add documentation for new experimentalUseDefaultDocumentDomain…
AtofStryker ff15d8d
Merge branch 'master' of github.com:cypress-io/cypress-documentation …
AtofStryker f0c21be
chore: give more in depth look at experiment and why it is necessary
AtofStryker 52d59af
Merge branch 'master' into feature/experimentalUseDefaultDocumentDomain
AtofStryker 12dcee7
chore: address comments from code review
AtofStryker 352fd85
Merge branch 'master' of github.com:cypress-io/cypress-documentation …
AtofStryker cea2285
Merge branch 'feature/experimentalUseDefaultDocumentDomain' of github…
AtofStryker 3d4fb3e
move disabling document.domain disclaimer up to discussion of injection
AtofStryker dce0200
chore: rework the experiment section
AtofStryker b3ee9a5
chore: apply suggestions from code review
AtofStryker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
<Alert type="warning"> | ||
|
||
<strong class="alert-header"><Icon name="exclamation-triangle"></Icon> Disabling | ||
`document.domain` Injection</strong> | ||
|
||
In some cases, `document.domain` injection may cause issues. As of Cypress | ||
[v12.4.0](https://on.cypress.io/changelog#12-4-0), disabling `document.domain` | ||
injection is available with the `experimentalSkipDomainInjection` option. Please | ||
read about this | ||
[experiment](/guides/references/experiments#Experimental-Skip-Domain-Injection) | ||
for more information | ||
|
||
</Alert> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just read the Examples-of-what-Cypress-does-under-the-hood section. It doesn't state WHY we set document.domain. This is primarily to allow sub-domain navigation correct? maybe call that out here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a spot for this in the cross origin testing guide. I think I can move the workaround up there and it will fit fairly well