Router extension config #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattoni
requested changes
Dec 12, 2023
| @@ -14,21 +14,26 @@ properties: | |||
| required: | |||
There was a problem hiding this comment.
Since this whole struct is part of the submit, and every part is 'nullable', lets have it be both 'nullable' and 'optional'. This is a change we will need to start making across the spec, because it's technically correct. The platform will treat any nullable type as also optional on submit, but will always RETURN null in that space.
Honestly, going forward, marking everything that is nullable as also optional would probably be safest. I can't think of a situation where it's important to have the distinction.
| @@ -14,21 +14,26 @@ properties: | |||
| required: | |||
| - redirect | |||
| - forward | |||
| - proxy | |||
| - caching | |||
| properties: | |||
| redirect: | |||
| nullable: true | |||
| type: object | |||
| required: | |||
There was a problem hiding this comment.
same comment as above. if they're 'nullable', make them also optional.
| proxy: | ||
| nullable: true | ||
| type: object | ||
| required: |
mattoni
approved these changes
Dec 13, 2023
mattoni
deleted the
blewis/eng-1742-update-api-spec-for-router-extension-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HTTP Caching and HTTP Proxy to the HTTP router extension config