Add 'throws Exception' to generated Java stepdef snippets

[pettermahlen]

The convention (or my convention at least - I think it is general) when writing unit tests is to have method signatures like this:

@Test
public void shouldDoSomethingSomeWay() throws Exception {
   // test code
}

This means you don't need to worry about catching any checked exceptions, and is a statement that 'any exceptions thrown out of this test means the test should fail'.

I think it is a good idea to do the same with step definitions. Would it make sense to add 'throws Exception' to the method signatures in Java snippets? I'll be happy to submit some code if so.

[aslakhellesoy]

That makes total sense. throws Throwable even.

[pettermahlen]

Seems I don't know how to make pull requests - issue 319 was created for this as well. :(

[baztian]

Why did you choose to throw Throwable over Exception? Only classes deriving from Exception have to be added to the signature.

[aslakhellesoy]

I can't remember now. throwing Exception should be fine.

[baztian]

So wouldn't it be more appropriate to output "throw Exception" in the generated snippets? Or do you avoid that change as it doesn't look well in already established test suites?

[aslakhellesoy]

Your suggestion sounds good. Please send a PR

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.