Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for monochrome pretty format #221

Closed
jharmn opened this issue Feb 24, 2012 · 6 comments
Closed

Add support for monochrome pretty format #221

jharmn opened this issue Feb 24, 2012 · 6 comments

Comments

@jharmn
Copy link

jharmn commented Feb 24, 2012

Further details were posted in the Cukes group. The basic gist is that the cucumber.monochrome system property has apparently been removed, so there is no other means to eliminate color formatting in pretty output at the moment.
http://groups.google.com/group/cukes/browse_thread/thread/5e87794784d9797b
@klausbayrhammer
Copy link
Contributor

The desired behavior would be to have color formatting by default and disable it using a system property cucumber.monochrome=true?

@jharmn
Copy link
Author

jharmn commented Feb 27, 2012

Exactly. The color pretty print is perfect for normal interactive BDD (devs, qa, POs, etc) use, but in certain situations (such as CI/CD deployments in Jenkins/Go/etc), the monochrome output is preferrable.

@hutchy2570
Copy link
Contributor

I have added support for this flag in my branch SHA: d37bdf6

If this is the kind of thing you're looking for I'll create a pull request.

@jharmn
Copy link
Author

jharmn commented Feb 29, 2012

Looks to be precisely what I was looking for, and seems to address the prior "TODO". Thanks!

hutchy2570 pushed a commit to lgi-kitd/cucumber-jvm that referenced this issue Mar 1, 2012
Fixed cucumber#232 & cucumber#221
89281a3 
Updated JUnitFormatter to use Appendable.
Updated FormatterFactory to wrap File in FileWriter
Updated FormatterFactory to create directories required for files
Updated FormatterFactory to add cucumber.monochrome flag to be passed to the Pretty & Progress formatters
@aslakhellesoy
Copy link
Contributor

This was fixed in 1.0.0

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aslakhellesoy @jharmn @klausbayrhammer @hutchy2570