checking for dry run option before running hooks.

make sure that dryRun has not been set before running hooks.
cucumber · Dec 28, 2012 · a5ace1a · a5ace1a
1 parent ecdbd77
commit a5ace1a
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 4 deletions.
diff --git a/core/src/main/java/cucumber/runtime/Runtime.java b/core/src/main/java/cucumber/runtime/Runtime.java
@@ -180,8 +180,10 @@ public void runAfterHooks(Reporter reporter, Set<Tag> tags) {
     }
 
     private void runHooks(List<HookDefinition> hooks, Reporter reporter, Set<Tag> tags, boolean isBefore) {
-        for (HookDefinition hook : hooks) {
-            runHookIfTagsMatch(hook, reporter, tags, isBefore);
+        if (!runtimeOptions.dryRun) {
+	    	for (HookDefinition hook : hooks) {
+	            runHookIfTagsMatch(hook, reporter, tags, isBefore);
+	        }
         }
     }
 

diff --git a/core/src/test/java/cucumber/runtime/RuntimeTest.java b/core/src/test/java/cucumber/runtime/RuntimeTest.java
@@ -153,16 +153,29 @@ public void non_strict_with_errors() {
 
         assertEquals(0x1, runtime.exitStatus());
     }
-
+    
     @Test
+    public void dry_run_set() {
+        Runtime runtime = createDryRunRuntime();
+        runtime.addError(new RuntimeException());
+
+        assertEquals(0x1, runtime.exitStatus());
+    }
+
+
+	@Test
     public void strict_with_errors() {
         Runtime runtime = createStrictRuntime();
         runtime.addError(new RuntimeException());
 
         assertEquals(0x1, runtime.exitStatus());
     }
 
-    private Runtime createStrictRuntime() {
+	private Runtime createDryRunRuntime() {
+		return createRuntime("--dry-run");
+	}
+
+	private Runtime createStrictRuntime() {
         return createRuntime("-g anything", "--strict");
     }