Fix #1084 #1085
Merged
Fix #1084 #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 9, 2019 21:10
* master: Update size snapshots # Conflicts: # packages/jss-preset-default/.size-snapshot.json # packages/react-jss/.size-snapshot.json
|
I will validate this fix tomorrow morning |
added 2 commits
April 10, 2019 13:47
|
@kof, please review |
HenriBeck
pushed a commit
that referenced
this pull request
Apr 14, 2019
* master: (24 commits) Fix #1084 (#1085) Update size snapshots [jss-plugin-expand]Added the ability to expand the attributes for border-bottom (#1083) Update react-jss.md (#1078) Fix typspec for default unit plugin (#1077) Delete CNAME Create CNAME v10.0.0-alpha.16 fix versions manually update changelog, make build Add local yarn version (#1071) update snapshots Update size-snapshots v10.0.0-alpha.15 update changelog, make build Update to css-vendor@2.0.1 (#1068) Improve IE 11 support (#1065) fix changelog v10.0.0-alpha.14 [jss] Add support for multiple referenced keyframes (#1063) ... # Conflicts: # packages/jss-plugin-default-unit/.size-snapshot.json # packages/jss-preset-default/.size-snapshot.json # packages/jss-starter-kit/.size-snapshot.json # packages/jss/.size-snapshot.json # packages/react-jss/.size-snapshot.json # packages/react-jss/src/types.js # packages/react-jss/src/withStyles.js
bhupinderbola
pushed a commit
to bhupinderbola/jss
that referenced
this pull request
Sep 17, 2019
* Fix cssinjs#1084 When the props have the same length while sorting in jss-plugin-props-sort, we check if the first prop is bigger than the second one and return 1 then. That way we should have a consistent output of orders even across different node versions * Fix sorting * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What would you like to add/fix?
When the props have the same length while sorting in jss-plugin-props-sort, we check if the first prop is bigger than the second one and return 1 then. That way we should have a consistent output of orders even across different node versions
Corresponding issue (if exists): #1084