Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: windows build in CI fails #868

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Problem: windows build in CI fails #868

merged 3 commits into from
Feb 14, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Feb 11, 2023 •
edited
Loading

Solution:

  • patch grocksdb to remove binding of not exported apis
  • add workflow to test windows build in PR

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang force-pushed the fix-windows branch 4 times, most recently from 5f4a37a to 8731bec Compare February 14, 2023 09:45
@yihuang yihuang changed the title Problem: cross-compiling for windows platform not supported Problem: windows build in CI fails Feb 14, 2023
@yihuang yihuang marked this pull request as ready for review February 14, 2023 09:46
@yihuang yihuang requested a review from a team as a code owner February 14, 2023 09:46
@yihuang yihuang requested review from mmsqe and thomas-nguy and removed request for a team February 14, 2023 09:46
@yihuang yihuang force-pushed the fix-windows branch 2 times, most recently from c8177ce to 391e74c Compare February 14, 2023 09:47
yihuang
yihuang commented Feb 14, 2023
View reviewed changes
@yihuang
Problem: windows build in CI fails
0909326 
Solution:
- patch grocksdb to remove binding of not exported apis
- add workflow to test windows build in PR
@yihuang yihuang enabled auto-merge (squash) February 14, 2023 13:14
@yihuang yihuang merged commit 43e96a4 into crypto-org-chain:release/v1.0.x Feb 14, 2023
@yihuang yihuang deleted the fix-windows branch February 14, 2023 22:06
@yihuang yihuang mentioned this pull request Feb 15, 2023
Closed
yihuang added a commit to yihuang/cronos that referenced this pull request Feb 15, 2023
@yihuang
Problem: windows build in CI fails (crypto-org-chain#868)
cd726ec 
* Problem: windows build in CI fails

Solution:
- patch grocksdb to remove binding of not exported apis
- add workflow to test windows build in PR

* use crypto-org-chain fork
yihuang added a commit to yihuang/cronos that referenced this pull request Feb 16, 2023
@yihuang
Problem: cross-compiling don't work
f278590 
Solution:
- remove some obstacles, now it at least works for linux.
- darwin still need some fixes in nixpkgs side, see: NixOS/nixpkgs#216431

update release flow

upload build result to check

Problem: windows build in CI fails (crypto-org-chain#868)

* Problem: windows build in CI fails

Solution:
- patch grocksdb to remove binding of not exported apis
- add workflow to test windows build in PR

* use crypto-org-chain fork

update gomod2nix

fix mac cross compiling

fix cross-compiling tarball

windows bundle script

support windows tarball

add unified job for cross-compiling

grocksdb link options

configure differnt build machine for different hosts

don't fail fast
@yihuang yihuang mentioned this pull request Feb 16, 2023
Closed
yihuang added a commit to yihuang/cronos that referenced this pull request Feb 22, 2023
@yihuang
Problem: cross-compiling don't work
ff5a80d 
Solution:
- remove some obstacles, now it at least works for linux.
- darwin still need some fixes in nixpkgs side, see: NixOS/nixpkgs#216431

update release flow

upload build result to check

Problem: windows build in CI fails (crypto-org-chain#868)

* Problem: windows build in CI fails

Solution:
- patch grocksdb to remove binding of not exported apis
- add workflow to test windows build in PR

* use crypto-org-chain fork

update gomod2nix

fix mac cross compiling

fix cross-compiling tarball

windows bundle script

support windows tarball

add unified job for cross-compiling

grocksdb link options

configure differnt build machine for different hosts

don't fail fast

simplify

don't run unittest in nix build

update grocksdb dependency

tidy

fix grocksdb

grocksdb upstream repo
yihuang added a commit to yihuang/cronos that referenced this pull request Feb 22, 2023
@yihuang
Problem: cross-compiling don't work
0d052af 
Solution:
- remove some obstacles, now it at least works for linux.
- darwin still need some fixes in nixpkgs side, see: NixOS/nixpkgs#216431

update release flow

upload build result to check

Problem: windows build in CI fails (crypto-org-chain#868)

* Problem: windows build in CI fails

Solution:
- patch grocksdb to remove binding of not exported apis
- add workflow to test windows build in PR

* use crypto-org-chain fork

update gomod2nix

fix mac cross compiling

fix cross-compiling tarball

windows bundle script

support windows tarball

add unified job for cross-compiling

grocksdb link options

configure differnt build machine for different hosts

don't fail fast

simplify

don't run unittest in nix build

update grocksdb dependency

tidy

fix grocksdb

grocksdb upstream repo
yihuang added a commit to yihuang/cronos that referenced this pull request Feb 22, 2023
@yihuang
Problem: cross-compiling don't work
0c433a5 
Solution:
- remove some obstacles, now it at least works for linux.
- darwin still need some fixes in nixpkgs side, see: NixOS/nixpkgs#216431

update release flow

upload build result to check

Problem: windows build in CI fails (crypto-org-chain#868)

* Problem: windows build in CI fails

Solution:
- patch grocksdb to remove binding of not exported apis
- add workflow to test windows build in PR

* use crypto-org-chain fork

update gomod2nix

fix mac cross compiling

fix cross-compiling tarball

windows bundle script

support windows tarball

add unified job for cross-compiling

grocksdb link options

configure differnt build machine for different hosts

don't fail fast

simplify

don't run unittest in nix build

update grocksdb dependency

tidy

fix grocksdb

grocksdb upstream repo
yihuang added a commit to yihuang/cronos that referenced this pull request Feb 22, 2023
@yihuang
Problem: cross-compiling don't work
89746a1 
Solution:
- remove some obstacles, now it at least works for linux.
- darwin still need some fixes in nixpkgs side, see: NixOS/nixpkgs#216431

update release flow

upload build result to check

Problem: windows build in CI fails (crypto-org-chain#868)

* Problem: windows build in CI fails

Solution:
- patch grocksdb to remove binding of not exported apis
- add workflow to test windows build in PR

* use crypto-org-chain fork

update gomod2nix

fix mac cross compiling

fix cross-compiling tarball

windows bundle script

support windows tarball

add unified job for cross-compiling

grocksdb link options

configure differnt build machine for different hosts

don't fail fast

simplify

don't run unittest in nix build

update grocksdb dependency

tidy

fix grocksdb

grocksdb upstream repo
yihuang added a commit that referenced this pull request Feb 23, 2023
@yihuang
Problem: cross-compiling don't work (#874)
65d7297 
* Problem: cross-compiling don't work

Solution:
- remove some obstacles, now it at least works for linux.
- darwin still need some fixes in nixpkgs side, see: NixOS/nixpkgs#216431

update release flow

upload build result to check

Problem: windows build in CI fails (#868)

* Problem: windows build in CI fails

Solution:
- patch grocksdb to remove binding of not exported apis
- add workflow to test windows build in PR

* use crypto-org-chain fork

update gomod2nix

fix mac cross compiling

fix cross-compiling tarball

windows bundle script

support windows tarball

add unified job for cross-compiling

grocksdb link options

configure differnt build machine for different hosts

don't fail fast

simplify

don't run unittest in nix build

update grocksdb dependency

tidy

fix grocksdb

grocksdb upstream repo

* Update app/versiondb_placeholder.go

Signed-off-by: yihuang <huang@crypto.com>

* update nixpkgs

* temp

* cleanup and remove goreleaser

* use buildPackages.go

* fix workflow

* fix workflow

* Update scripts/release.sh

Signed-off-by: yihuang <huang@crypto.com>

* fix default name of GITHUB_REF_NAME

* fix ref name

* escape ref name to be used as file name

* fix escape

* fix arm64

* fix darwin cross-compiling

* fix darwin cross-compiling

---------

Signed-off-by: yihuang <huang@crypto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmsqe mmsqe mmsqe approved these changes

@thomas-nguy thomas-nguy Awaiting requested review from thomas-nguy thomas-nguy is a code owner automatically assigned from crypto-org-chain/cronos-dev

@leejw51crypto leejw51crypto Awaiting requested review from leejw51crypto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuang @mmsqe