object.size.reduce #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required input to extend JAGS-model is no longer class "runjags" but instead class "BayLum.list". The MCMC-list of runjags_object (one output of AgeS_Computation) was stripped to save space (The MCMC-list appears already in the first level of the output as "Sample")
Required input to extend JAGS-model is no longer class "runjags" but instead class "BayLum.list". The MCMC-list of runjags_object (one output of AgeS_Computation) was stripped to save space (The MCMC-list appears already in the first level of the output as "Sampling")
It is "Sampling", not "Sample".
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
- Coverage 68.55% 68.51% -0.04%
==========================================
Files 18 18
Lines 2194 2198 +4
==========================================
+ Hits 1504 1506 +2
- Misses 690 692 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
RLumSK
requested changes
Mar 11, 2023
R/AgeS_Computation.R
Outdated
| @@ -13,7 +13,7 @@ | |||
| #' \code{DATA} contains informations for more than one sample. | |||
| #' If there is stratigraphic relations between samples, informations in DATA must be ordered by order of increasing ages. | |||
| #' See the details section to for more informations. | |||
| #' (2): An object of class "runjags" which is provided by the output of [AgeS_Computation]. When input of class "runjags" is identified, no new JAGS model is created. Instead, the JAGS model specified by the "runjags" object is extended. Useful for when convergence was not originally achieved and a complete restart is not desirable. | |||
| #' (2): An object of class "BayLum.list" which is provided by the output of [AgeS_Computation]. When input of class "BayLum.list" is identified, no new JAGS model is created. Instead, the JAGS model specified by the AgeS_Computation output is extended. Useful for when convergence was not originally achieved and a complete restart is not desirable. | |||
There was a problem hiding this comment.
Please use markdown syntax:
- "BayLum.list" -> `BayLum.list`
- AgeS_Computation -> [AgeS_Computation]
The first renders the term correctly in the manual, and the second links to the function.
R/Age_OSLC14.R
Outdated
| @@ -15,7 +15,7 @@ | |||
| #' \code{DATA} contains information for more than one sample. | |||
| #' If there is stratigraphic relations between samples, informations in DATA must be ordered by order of | |||
| #' increasing ages. See the details section to for more informations. | |||
| #' (2): an object of class "runjags" which is provided by the output of [Age_OSLC14]. When input of class "runjags" is identified, no new JAGS model is created. Instead, the JAGS model specified by the "runjags" object is extended. Useful for when convergence was not originally achieved and a complete restart is not desirable. | |||
| #' (2): an object of class "BayLum.list" which is provided by the output of [Age_OSLC14]. When input of class "BayLum.list" is identified, no new JAGS model is created. Instead, the JAGS model specified within the BayLum.list is extended. Useful for when convergence was not originally achieved and a complete restart is not desirable. | |||
There was a problem hiding this comment.
Same as before, please use markdown syntax:
- "BayLum.list" -> `BayLum.list`
|
@imgoej I forgot, please also create a NEWS entry in NEWS.Rmd and then render it with |
|
@imgoej Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MCMC-list provided by the output of runjags can easily become huge in terms of bytes. It is therefore not prudent to have that list appear twice in the return output of these functions (once as "Sampling" and once as "mcmc" inside "runjags_object").
I therefore set "mcmc" of "runjags_object" to a string pointing to where is "Sampling" is. If input is a BayLum.list (output of these functions and therefore not a generated DataFile), "mcmc" inside "runjags_object" takes on "Sampling" as its value.