Skip to content

fix: solved issue for the ledgerId restriction as a string of array #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

KulkarniShashank
Copy link
Contributor

What

Resolved the issue related to the ledgerId restriction when passed as a string of an array.

Why

The existing implementation did not handle the ledgerId restriction properly when provided as a string within an array. This caused unexpected behavior and potential errors in certain scenarios. The fix ensures that the ledgerId restriction is correctly processed when presented in this format.

How

Modified the relevant function to correctly parse and handle ledgerId when passed as a string within an array.
Added test cases to cover the scenarios where the issue was identified.
Updated documentation to reflect the corrected behavior and provide examples of using ledgerId in this specific format.

Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@nishad-ayanworks nishad-ayanworks merged commit bf5a752 into develop Feb 28, 2024
@KulkarniShashank KulkarniShashank deleted the fix/shared-wallet-payload branch March 8, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants